This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix gcc-style %sycl_options on Windows #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, -lsycl have to be changed to -lsycl6 for the gcc-style invocations. Note that clang-cl style had been updated sycl.lib -> sycl6.lib before. I originally tried to get rid of explicit library name by using "-fsycl" instead but it would break some tests for explicit manual compilation.
againull
approved these changes
Oct 4, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
On windows, -lsycl have to be changed to -lsycl6 for the gcc-style invocations. Note that clang-cl style had been updated sycl.lib -> sycl6.lib before. I originally tried to get rid of explicit library name by using "-fsycl" instead but it would break some tests for explicit manual compilation.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…1306) On windows, -lsycl have to be changed to -lsycl6 for the gcc-style invocations. Note that clang-cl style had been updated sycl.lib -> sycl6.lib before. I originally tried to get rid of explicit library name by using "-fsycl" instead but it would break some tests for explicit manual compilation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, -lsycl have to be changed to -lsycl6 for the gcc-style invocations. Note that clang-cl style had been updated sycl.lib -> sycl6.lib before.
I originally tried to get rid of explicit library name by using "-fsycl" instead but it would break some tests for explicit manual compilation.