This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[cmake] validate CHECK_SYCL_ALL more thoroughly during configuration
#1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a bit of trouble working out why lit was failing to start after configuration had succceeded. Turns out I was passing a partial tuple to cmake `-DCHECK_SYCL_ALL` due to a typo in a shell variable. This patch verifies that both parts of each tuple in the `CHECK_SYCL_ALL` variable are nonempty and terminates configuration with an error message otherwise, which should make it a bit more obvious what's happening.
steffenlarsen
approved these changes
Oct 12, 2022
|
Are these test failures expected? I can't see how this would cause test failures? |
Yes. These failures were fixed in intel/llvm yesterday but have not reached the build used by this CI yet. This PR is good to go. 😄 |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
intel#1321) I had a bit of trouble working out why lit was failing to start after configuration had succceeded. Turns out I was passing a partial tuple to cmake `-DCHECK_SYCL_ALL` due to a typo in a shell variable. This patch verifies that both parts of each tuple in the `CHECK_SYCL_ALL` variable are nonempty and terminates configuration with an error message otherwise, which should make it a bit more obvious what's happening.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
intel/llvm-test-suite#1321) I had a bit of trouble working out why lit was failing to start after configuration had succceeded. Turns out I was passing a partial tuple to cmake `-DCHECK_SYCL_ALL` due to a typo in a shell variable. This patch verifies that both parts of each tuple in the `CHECK_SYCL_ALL` variable are nonempty and terminates configuration with an error message otherwise, which should make it a bit more obvious what's happening.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a bit of trouble working out why lit was failing to start after configuration had succceeded. Turns out I was passing a partial tuple to cmake
-DCHECK_SYCL_ALLdue to a typo in a shell variable.This patch verifies that both parts of each tuple in the
CHECK_SYCL_ALLvariable are nonempty and terminates configuration with an error message otherwise, which should make it a bit more obvious what's happening.