Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL-MLIR] Start with only the single_task.cpp test case #1330

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

whitneywhtsang
Copy link

Signed-off-by: Tsang, Whitney [email protected]

@whitneywhtsang whitneywhtsang added the sycl-mlir Pull requests or issues for sycl-mlir branch label Oct 18, 2022
@whitneywhtsang whitneywhtsang self-assigned this Oct 18, 2022
@whitneywhtsang whitneywhtsang marked this pull request as draft October 18, 2022 03:47
Copy link

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits in the test-case.

On a more general note, I'm wondering if introducing a sub-directory with new tests is the most efficient way to test SYCL-MLIR.

The repository already contains a rather large set of SYCL tests that we could potentially re-use instead of introducing lots of new tests.
We could create a white-list of tests that should be working on our branch and alter the CMake target (or create a new one) to only run the tests in the white-list using the --filter feature of llvm-lit.

What do you think?

Signed-off-by: Tsang, Whitney <[email protected]>
@whitneywhtsang
Copy link
Author

whitneywhtsang commented Oct 18, 2022

The buildbots are failing because sycl-targets suffix with -syclmlir is unhandled by non-sycl-mlir clang.
When testing PR from intel/llvm repo sycl-mlir branch, we will be using the sycl-mlir clang, and the test case should pass with check-sycl-all. (Tested locally for opencl:cpu)

Signed-off-by: Tsang, Whitney <[email protected]>
@whitneywhtsang whitneywhtsang marked this pull request as ready for review October 18, 2022 16:06
Copy link

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks.

IMHO we should just make sure to notify the user that Nvidia and AMD are currently not supported by the SYCL-MLIR-based compilation flow (other than just failing the test).

@whitneywhtsang whitneywhtsang merged commit b8c6aa0 into sycl-mlir Oct 19, 2022
@whitneywhtsang whitneywhtsang deleted the waihungt/single_task branch October 19, 2022 14:28
whitneywhtsang added a commit that referenced this pull request Jan 13, 2023
whitneywhtsang added a commit that referenced this pull request Jan 18, 2023
whitneywhtsang added a commit that referenced this pull request Jan 25, 2023
whitneywhtsang added a commit that referenced this pull request Jan 27, 2023
whitneywhtsang added a commit that referenced this pull request Feb 17, 2023
whitneywhtsang added a commit that referenced this pull request Mar 1, 2023
whitneywhtsang added a commit that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants