Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] tests to validate sub-devices have parent (or not) #1346

Merged

Conversation

cperkinsintel
Copy link

These are the tests for intel/llvm#7167

All devices available when using ONEAPI_DEVICE_SELECTOR are root devices, even those which are gotten via the sub-device selection choices ( e.g. ONEAPI_DEVICE_SELECTOR=level_zero:. ). In this PR we are ensuring that all devices gotten with that environment variable are root devices that have no parent. And, conversely, that when not using it, any sub-devices do report the correct parent.

Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cperkinsintel
Copy link
Author

/verify with intel/llvm#7167

steffenlarsen pushed a commit to intel/llvm that referenced this pull request Nov 3, 2022
…#7167)

All devices available when using ONEAPI_DEVICE_SELECTOR are root
devices, even those which are gotten via the sub-device selection
choices ( e.g. `ONEAPI_DEVICE_SELECTOR=level_zero:*.*` ). In this PR we
are ensuring that those devices pretend to be root devices.

Tests for this are here:
intel/llvm-test-suite#1346
@steffenlarsen steffenlarsen merged commit 26e147d into intel:intel Nov 3, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
remove PVC tests. They will be added in the public repo
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
These are the tests for intel/llvm#7167

All devices available when using ONEAPI_DEVICE_SELECTOR are root devices, even those which are gotten via the sub-device selection choices ( e.g. ONEAPI_DEVICE_SELECTOR=level_zero:*.* ). In this PR we are ensuring that all devices gotten with that environment variable are root devices that have no parent. And, conversely, that when not using it, any sub-devices do report the correct parent.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…-test-suite#1346)

These are the tests for intel#7167

All devices available when using ONEAPI_DEVICE_SELECTOR are root devices, even those which are gotten via the sub-device selection choices ( e.g. ONEAPI_DEVICE_SELECTOR=level_zero:*.* ). In this PR we are ensuring that all devices gotten with that environment variable are root devices that have no parent. And, conversely, that when not using it, any sub-devices do report the correct parent.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants