Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD]Add test to validate correct split #1352

Merged
merged 4 commits into from
Dec 14, 2022
Merged

[SYCL][ESIMD]Add test to validate correct split #1352

merged 4 commits into from
Dec 14, 2022

Conversation

fineg74
Copy link

@fineg74 fineg74 commented Oct 26, 2022

No description provided.

@fineg74
Copy link
Author

fineg74 commented Oct 26, 2022

Complementary compiler PR: intel/llvm#7191

Comment on lines 16 to 17
// RUN: %clangxx -O0 -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %GPU_RUN_PLACEHOLDER %t.out

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking comment: it may be a bit more convenient if a different name is used:

Suggested change
// RUN: %clangxx -O0 -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t.out
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %GPU_RUN_PLACEHOLDER %t.out
// RUN: %clangxx -O0 -fsycl -fno-sycl-device-code-split-esimd -Xclang -fsycl-allow-func-ptr %s -o %t0.out
// RUN: env IGC_VCSaveStackCallLinkage=1 IGC_VCDirectCallsOnly=1 %GPU_RUN_PLACEHOLDER %t0.out

@fineg74 fineg74 changed the title Add test to validate correct split [SYCL][ESIMD]Add test to validate correct split Oct 27, 2022
@fineg74
Copy link
Author

fineg74 commented Dec 2, 2022

/verify with intel/llvm#7191

@kbobrovs
Copy link

kbobrovs commented Dec 8, 2022

Please provide explanation for the test falures

@fineg74
Copy link
Author

fineg74 commented Dec 8, 2022

Linux Test failures for InvokeSimd/invoke_simd_conv.cpp are expected.
Windows Test Failures :
SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp
SYCL :: Regression/set-arg-local-accessor.cpp
are not related to the change

@v-klochkov
Copy link

The PR was updated long ago last time. I rebased it to restart CI and be on safer side.

@fineg74
Copy link
Author

fineg74 commented Dec 13, 2022

Linux test failures:
SYCL :: Plugin/level_zero_ext_intel_queue_index.cpp
SYCL :: Scheduler/ReleaseResourcesTest.cpp

are not related to the test

@fineg74
Copy link
Author

fineg74 commented Dec 13, 2022

Windows test failures:
SYCL :: Basic/group_async_copy.cpp
SYCL :: DeviceLib/imf_fp16_trivial_test.cpp
SYCL :: DeviceLib/imf_fp32_test.cpp
SYCL :: DeviceLib/imf_half_type_cast.cpp
SYCL :: Plugin/level_zero_ext_intel_queue_index.cpp
SYCL :: Reduction/reduction_big_data.cpp
SYCL :: Reduction/reduction_nd_N_vars.cpp
SYCL :: Reduction/reduction_nd_conditional.cpp
SYCL :: Reduction/reduction_nd_lambda.cpp
SYCL :: Reduction/reduction_nd_rw.cpp
SYCL :: Reduction/reduction_range_1d_dw.cpp
SYCL :: Reduction/reduction_range_1d_dw_64bit.cpp
SYCL :: Reduction/reduction_range_1d_rw.cpp
SYCL :: Reduction/reduction_range_2d_dw.cpp
SYCL :: Reduction/reduction_range_2d_rw.cpp
SYCL :: Reduction/reduction_range_3d_dw.cpp
SYCL :: Reduction/reduction_range_3d_rw.cpp
SYCL :: Reduction/reduction_range_N_vars.cpp
SYCL :: Reduction/reduction_range_lambda.cpp
SYCL :: Reduction/reduction_range_usm_dw.cpp
SYCL :: Reduction/reduction_usm.cpp
SYCL :: Reduction/reduction_usm_dw.cpp
SYCL :: Scheduler/ReleaseResourcesTest.cpp
are not related to the test

@v-klochkov v-klochkov merged commit 5f8f95b into intel:intel Dec 14, 2022
@v-klochkov
Copy link

v-klochkov commented Dec 14, 2022

@fineg74 - Thank you for the fix. It is merged.

The test still has this line added Aug 16: "// TODO: enable on Windows once driver is ready".
Can you please try removing that line (and requirement of 'linux') to see if newer GPU RT is good already?

@fineg74 fineg74 deleted the esimdSplitFixTest branch December 14, 2022 03:00
@fineg74
Copy link
Author

fineg74 commented Dec 14, 2022

Still failing (#1451) Probably needs different command line, but I am not sure how to do it platform dependent.

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
[SYCL] Change library loading and fix esimd selector function
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
* Add test to validate correct split
* Disable execution of a test generated with -O0 option until crash issue is resolved
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…e#1352)

* Add test to validate correct split
* Disable execution of a test generated with -O0 option until crash issue is resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants