add a new query test that uses the new API #1358
Conversation
|
It looks like this is an unrelated failure: |
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // REQUIRES: matrix | ||
|
|
There was a problem hiding this comment.
Could you please add a comment clarifying what exactly is checked by this test. It is not clear which API is being tested.
There was a problem hiding this comment.
We recently updated the matrix API to introduce a new argument "use" in joint_matrix type.
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_matrix/sycl_ext_oneapi_matrix.asciidoc
the old API was moved to https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/deprecated/sycl_ext_oneapi_matrix_no_use.asciidoc
The specific changes that I am making here are done in intel/llvm#6981
| constexpr int TN = myparams2::N; | ||
| constexpr int TK = myparams2::K; | ||
|
|
||
| std::cout << "AMX query sizes are: M " << TM << " N " << TN << " K " << TK |
There was a problem hiding this comment.
@yanfeng3721 if there is "failed" in line48 and another "passed" in line166, can the test infrastructure detect it is failed?
There was a problem hiding this comment.
@yanfeng3721 if there is "failed" in line48 and another "passed" in line166, can the test infrastructure detect it is failed?
Hi @yubingex007-a11y, I think it can be checked by FileCheck. Please refer to usage doc https://llvm.org/docs/CommandGuide/FileCheck.html.
Also, there is an example test as reference: https://github.com/intel/llvm-test-suite/blob/intel/SYCL/DiscardEvents/discard_events_usm.cpp
There was a problem hiding this comment.
// CHECK: The test passed.
#include "discard_events_test_queue_ops.hpp"
#include <iostream>
int main(int Argc, const char *Argv[]) {
sycl::property_list Props{
sycl::property::queue::in_order{},
sycl::ext::oneapi::property::queue::discard_events{}};
sycl::queue Q(Props);
TestQueueOperations(Q);
TestQueueOperationsViaSubmit(Q);
std::cout << "The test passed." << std::endl;
i think two "// CHECK: passed" should be added according to yanfeng's comments
|
Unrelated failures: 'SYCL :: ESIMD/api/functional/ctors/ctor_broadcast_fp_extra.cpp is failing on Linux @againull, Can you help merge? |
I see internal bug created for this failure - SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp is failing on Windows Is there a github issue or internal bug created for this failure? - 'SYCL :: ESIMD/api/functional/ctors/ctor_broadcast_fp_extra.cpp is failing on Linux |
It looks like ESIMD/api/functional/ctors/ctor_broadcast_fp_extra.cpp is going to covered by #1401 |
CMPLRTST-18399: 1. remove feature 'matrix-pvc', use 'matrix' for pvc/amx/spr instead; 2. add feature 'matrix-ats'; 3. add checker for current running cpu codename.
The changes that are being tested are introduced in intel/llvm#6981