Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Add 'spec' tests to SYCL/InvokeSimd #1360

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Add 'spec' tests to SYCL/InvokeSimd #1360

merged 7 commits into from
Dec 7, 2022

Conversation

fveselov
Copy link

@fveselov fveselov commented Nov 2, 2022

No description provided.

@fveselov fveselov changed the title Add 'spec' category to invoke_simd tests Add 'spec' tests to SYCL/InvokeSimd Nov 2, 2022
@fveselov
Copy link
Author

fveselov commented Nov 3, 2022

Jenkins/pre-ci-windows fail unrelated:

[2022-11-02T15:23:52.966Z] Failed Tests (1):
[2022-11-02T15:23:52.966Z]   SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp

kbobrovs
kbobrovs reviewed Nov 3, 2022
View reviewed changes
SYCL/InvokeSimd/spec/IMPL_SUBGROUP/popcnt.cpp Outdated
@@ -0,0 +1,19 @@
// TODO: enable on Windows once driver is ready
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is not part of the spec, it should rather go to the 4th category we discussed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbobrovs,
As we discussed there will be 4 categories: Spec, Feature, Regression and Bench/Workload (last one goes to closed-source repo). Do I need to move only IMPL_SUBGROUP/popcnt.cpp test to other category or all tests in IMPL_SUBGROUP directory? And in what category exactly?

Copy link

@kbobrovs kbobrovs Nov 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following should not be part of the SPEC subsuite:

  • *pvc*
  • popcnt, scale

Copy link
Author

@fveselov fveselov Nov 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason why there is a separate test for PVC is because allowed simd sizes differ on PVC from all other platforms and I don't know how to recognize the platform at compile time.

Moving PVC version of the test to another category will lead to code duplication or use of relative path to common code. Should I move all simd_size tests to the 'regression' category?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reorganized and renamed simd_size tests so there is no explicit reference to specific platforms in the names

kbobrovs
kbobrovs reviewed Nov 3, 2022
View reviewed changes
kbobrovs
kbobrovs reviewed Nov 3, 2022
View reviewed changes
@fveselov fveselov requested a review from kbobrovs November 17, 2022 15:33
kbobrovs
kbobrovs reviewed Nov 17, 2022
View reviewed changes
SYCL/InvokeSimd/spec/simd_size/simd_size.cpp Outdated
Comment on lines 3 to 9
// UNSUPPORTED: cuda || hip
//
// Test not intended to run on PVC
// UNSUPPORTED: gpu-intel-pvc
//
// TODO: enable when Jira ticket resolved
// XFAIL: gpu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems messy. 2 UNSPPORTED + XFAIL which encloses them logically. Please check here and in other places that there is no unnecessary overlap in filters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed overlapping filters, but can't get rid of XFAIL till Jira issue resolved.

@fveselov
Copy link
Author

Both Linux and Window CI fails are unrelated to changes:

[2022-11-22T11:57:19.053Z] Failed Tests (2):
[2022-11-22T11:57:19.053Z]   SYCL :: DeprecatedFeatures/deprecated_sycl_device_filter.cpp
[2022-11-22T11:57:19.053Z]   SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp

@fveselov fveselov requested a review from kbobrovs November 22, 2022 12:42
@kbobrovs
Copy link

kbobrovs commented Dec 7, 2022

failures are unrelated, merging

@kbobrovs kbobrovs merged commit d69c64d into intel:intel Dec 7, 2022
@fveselov fveselov deleted the invoke_simd_spec branch December 7, 2022 19:11
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@myler
Merge pull request intel#1360 from myler/CMPLRTST-18479-xmain
4400152 
level_zero_device_free_mem.cpp is not supported on integrated devices
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@fveselov @bb-sycl
Add 'spec' tests to SYCL/InvokeSimd (intel#1360)
b236b6f
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@fveselov
Add 'spec' tests to SYCL/InvokeSimd (intel/llvm-test-suite#1360)
514ce8e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kbobrovs kbobrovs kbobrovs approved these changes

@rolandschulz rolandschulz Awaiting requested review from rolandschulz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fveselov @kbobrovs