This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL-MLIR] Add parallel_for.cpp #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsang, Whitney <[email protected]>
Signed-off-by: Tsang, Whitney <[email protected]>
Signed-off-by: Tsang, Whitney <[email protected]>
|
For the record IMO we should not add test cases that fail because it makes PRs appear as "red". The correct process is to add test coverage only after the PR that makes the test case pass has been merged in. |
whitneywhtsang
added a commit
to intel/llvm
that referenced
this pull request
Nov 10, 2022
Globals of `ext_vector_type` type used to represent as `memref<3xi64>`, which lowers to array type pointer in LLVM. This can cause link failures when files are compiled from different compilers. This PR changes globals of `ext_vector_type` type to be represented as `memref<vector<3xi64>>`, which lowers to vector type pointer, the same type as directly compile from `clang`. Note: After this PR, `parallel_for.cpp` can run successfully. Test case added in intel/llvm-test-suite#1374. Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
added a commit
that referenced
this pull request
Jan 13, 2023
* [SYCL-MLIR] Add parallel_for.cpp Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
added a commit
that referenced
this pull request
Jan 18, 2023
* [SYCL-MLIR] Add parallel_for.cpp Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
added a commit
that referenced
this pull request
Jan 25, 2023
* [SYCL-MLIR] Add parallel_for.cpp Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
added a commit
that referenced
this pull request
Jan 27, 2023
* [SYCL-MLIR] Add parallel_for.cpp Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
added a commit
that referenced
this pull request
Feb 17, 2023
* [SYCL-MLIR] Add parallel_for.cpp Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
added a commit
that referenced
this pull request
Mar 1, 2023
* [SYCL-MLIR] Add parallel_for.cpp Signed-off-by: Tsang, Whitney <[email protected]>
whitneywhtsang
added a commit
that referenced
this pull request
Mar 27, 2023
* [SYCL-MLIR] Add parallel_for.cpp Signed-off-by: Tsang, Whitney <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsang, Whitney [email protected]