Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD] Add tests for ESIMD functions accepting 64 bit offsets #1385

Merged
merged 11 commits into from
Dec 14, 2022
Merged

[SYCL][ESIMD] Add tests for ESIMD functions accepting 64 bit offsets #1385

merged 11 commits into from
Dec 14, 2022

Conversation

fineg74
Copy link

@fineg74 fineg74 commented Nov 16, 2022

Complementary compiler PR intel/llvm#7411

@fineg74
Copy link
Author

fineg74 commented Dec 1, 2022

/verify with intel/llvm#7411

@fineg74
Copy link
Author

fineg74 commented Dec 1, 2022

/verify with intel/llvm#7411

1 similar comment
@fineg74
Copy link
Author

fineg74 commented Dec 2, 2022

/verify with intel/llvm#7411

@fineg74
Copy link
Author

fineg74 commented Dec 2, 2022

/verify with intel/llvm#7411

@fineg74
Copy link
Author

fineg74 commented Dec 2, 2022

/verify with intel/llvm#7411

@fineg74
Copy link
Author

fineg74 commented Dec 2, 2022

/verify with intel/llvm#7411

@kbobrovs
Copy link

kbobrovs commented Dec 5, 2022

Please address test failures.

@fineg74
Copy link
Author

fineg74 commented Dec 5, 2022

Please address test failures.

Jenkins/llvm-test-suite: the result of /verify command passed
Jenkins/pre-ci-windows and Jenkins/pre-ci-linux failures are expected.

@fineg74
Copy link
Author

fineg74 commented Dec 7, 2022

/verify intel/llvm#7411

@@ -0,0 +1,18 @@
//==------------ lsc_usm_load_u64_64.cpp - DPC++ ESIMD on-device test
//---------==//

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment: Is this line needed? You could fit line1 and 2 into 1 by removing some '-' symbols.

// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to handle this test same way as you did for other tests.
I.e. have all the content of the main test in lsc_usm.cpp (not in this "Inputs" folder), and the other 64-bit version of the test would just include that lsc_usm.cpp

@v-klochkov
Copy link

@fineg74 - I cannot merge this as is because something is wrong with CI - it reported only clang-format check.
Please do the following for the test and ESIMD headers fix.
For the test:

git remote add intel_llvm https://github.com/intel/llvm-test-suite
git fetch intel_llvm
git merge intel_llvm/intel
git push origin 64BitOffsetTest

For the ESIMD headers fix:

git remote add intel_llvm https://github.com/intel/llvm
git fetch intel_llvm
git merge intel_llvm/sycl
git push origin 64BitOffset

@fineg74
Copy link
Author

fineg74 commented Dec 13, 2022

/verify with intel/llvm#7411

@fineg74
Copy link
Author

fineg74 commented Dec 14, 2022

llvm-test-suite failures

HostInteropTask/host-task-failure.cpp
Basic/group_async_copy.cpp
DeviceLib/imf_fp16_trivial_test.cpp
DeviceLib/imf_fp32_test.cpp
DeviceLib/imf_half_type_cast.cpp
Reduction/reduction_big_data.cpp
Reduction/reduction_nd_N_vars.cpp
Reduction/reduction_nd_conditional.cpp
Reduction/reduction_nd_dw.cpp
Reduction/reduction_nd_ext_half.cpp
Reduction/reduction_nd_lambda.cpp
Reduction/reduction_nd_rw.cpp
Reduction/reduction_range_1d_dw.cpp
Reduction/reduction_range_1d_dw_64bit.cpp
Reduction/reduction_range_1d_rw.cpp
Reduction/reduction_range_2d_dw.cpp
Reduction/reduction_range_2d_rw.cpp
Reduction/reduction_range_3d_dw.cpp
Reduction/reduction_range_3d_rw.cpp
Reduction/reduction_range_lambda.cpp
Reduction/reduction_range_usm_dw.cpp
Reduction/reduction_usm.cpp
Reduction/reduction_usm_dw.cpp

are not related to the change

@fineg74
Copy link
Author

fineg74 commented Dec 14, 2022

Linux failures:

ESIMD/api/esimd_rgba_smoke_64.cpp
ESIMD/usm_gather_scatter_rgba_64.cpp
are expected to fail without the code in compiler PR

Plugin/level_zero_ext_intel_queue_index.cpp
Scheduler/ReleaseResourcesTest.cpp
USM/copy2d.cpp
USM/fill2d.cpp
USM/memcpy2d.cpp
USM/memset2d.cpp
are not related to the change

@fineg74
Copy link
Author

fineg74 commented Dec 14, 2022

Windows failures
ESIMD/api/esimd_rgba_smoke_64.cpp
ESIMD/usm_gather_scatter_rgba_64.cpp
are expected to fail without code in compiler PR

Basic/scalar_vec_access.cpp
Basic/stream/auto_flush.cpp
HostInteropTask/host-task-failure.cpp
Regression/unoptimized_stream.cpp
Basic/subdevice_pi.cpp
KernelAndProgram/multiple-kernel-linking.cpp
Plugin/level_zero_ext_intel_queue_index.cpp
Scheduler/ReleaseResourcesTest.cpp
USM/copy2d.cpp
USM/fill2d.cpp
USM/memcpy2d.cpp
USM/memset2d.cpp
XPTI/kernel/basic.cpp
are not related to the change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants