-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL][ESIMD] Add tests for ESIMD functions accepting 64 bit offsets #1385
Conversation
This reverts commit ba74a04.
/verify with intel/llvm#7411 |
…o fix test compilation failure on Windows
/verify with intel/llvm#7411 |
1 similar comment
/verify with intel/llvm#7411 |
/verify with intel/llvm#7411 |
…nction to fix" This reverts commit 6285957.
/verify with intel/llvm#7411 |
/verify with intel/llvm#7411 |
Please address test failures. |
Jenkins/llvm-test-suite: the result of /verify command passed |
/verify intel/llvm#7411 |
@@ -0,0 +1,18 @@ | |||
//==------------ lsc_usm_load_u64_64.cpp - DPC++ ESIMD on-device test | |||
//---------==// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment: Is this line needed? You could fit line1 and 2 into 1 by removing some '-' symbols.
SYCL/ESIMD/lsc/Inputs/lsc_usm.hpp
Outdated
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to handle this test same way as you did for other tests.
I.e. have all the content of the main test in lsc_usm.cpp (not in this "Inputs" folder), and the other 64-bit version of the test would just include that lsc_usm.cpp
@fineg74 - I cannot merge this as is because something is wrong with CI - it reported only clang-format check.
For the ESIMD headers fix:
|
/verify with intel/llvm#7411 |
llvm-test-suite failures HostInteropTask/host-task-failure.cpp are not related to the change |
Linux failures: ESIMD/api/esimd_rgba_smoke_64.cpp Plugin/level_zero_ext_intel_queue_index.cpp |
Windows failures Basic/scalar_vec_access.cpp |
Complementary compiler PR intel/llvm#7411