-
Notifications
You must be signed in to change notification settings - Fork 130
Add matrix tests that use the new API (unified API) #1391
Conversation
… tests to a new folder legacy
The failing test on windows ( KernelAndProgram/kernel-bundle-merge-options-env.cpp ) is a known failure that was introduced by some other PR. I believe it's being investigated. |
…as they are not supported anymore
/verify with intel/llvm#7413 |
1 similar comment
/verify with intel/llvm#7413 |
/verify with intel/llvm#7413 |
@intel/llvm-reviewers-runtime, @steffenlarsen can you please help approve/merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only adds new tests, it doesn't change any existing ones. The CI failures that are seen are unrelated to these tests, therefore this Looks Good To Me.
Note that these new tests all require the matrix
feature (or a variant) and we don't provide that feature presently, in part because our CI machines don't have any capable machines yet. We should get that feature added in the near future.
@intel/llvm-reviewers-runtime, can you please help merge? The failures are unrelated. |
@@ -7,7 +7,7 @@ | |||
//===----------------------------------------------------------------------===// | |||
// REQUIRES: matrix | |||
|
|||
// RUN: %clangxx -fsycl %s -o %t.out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, i should have noticed that this file should be updated
This PR adapts t the matrix tests to the new API (unified API) and move the old API tests to a new folder "Legacy".
…m-test-suite#1391) This PR adapts t the matrix tests to the new API (unified API) and move the old API tests to a new folder "Legacy".
This PR adapts t the matrix tests to the new API (unified API) and move the old API tests to a new folder "Legacy".
This should be merged after the DPC++ changes are merged: intel/llvm#7413