Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Add matrix tests that use the new API (unified API) #1391

Merged
merged 7 commits into from
Dec 21, 2022

Conversation

dkhaldi
Copy link

@dkhaldi dkhaldi commented Nov 17, 2022

This PR adapts t the matrix tests to the new API (unified API) and move the old API tests to a new folder "Legacy".
This should be merged after the DPC++ changes are merged: intel/llvm#7413

@cperkinsintel
Copy link

The failing test on windows ( KernelAndProgram/kernel-bundle-merge-options-env.cpp ) is a known failure that was introduced by some other PR. I believe it's being investigated.

@dkhaldi
Copy link
Author

dkhaldi commented Dec 8, 2022

/verify with intel/llvm#7413

1 similar comment
@dkhaldi
Copy link
Author

dkhaldi commented Dec 12, 2022

/verify with intel/llvm#7413

@yubingex007-a11y
Copy link

/verify with intel/llvm#7413

@dkhaldi
Copy link
Author

dkhaldi commented Dec 19, 2022

@intel/llvm-reviewers-runtime, @steffenlarsen can you please help approve/merge?
The failures are unrelated.

Copy link

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only adds new tests, it doesn't change any existing ones. The CI failures that are seen are unrelated to these tests, therefore this Looks Good To Me.

Note that these new tests all require the matrix feature (or a variant) and we don't provide that feature presently, in part because our CI machines don't have any capable machines yet. We should get that feature added in the near future.

@dkhaldi
Copy link
Author

dkhaldi commented Dec 21, 2022

@intel/llvm-reviewers-runtime, can you please help merge? The failures are unrelated.

@romanovvlad romanovvlad merged commit cbbfcc6 into intel:intel Dec 21, 2022
@dkhaldi dkhaldi deleted the unified branch December 21, 2022 19:32
@@ -7,7 +7,7 @@
//===----------------------------------------------------------------------===//
// REQUIRES: matrix

// RUN: %clangxx -fsycl %s -o %t.out

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i should have noticed that this file should be updated

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
This PR adapts t the matrix tests to the new API (unified API) and move
the old API tests to a new folder "Legacy".
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…m-test-suite#1391)

This PR adapts t the matrix tests to the new API (unified API) and move
the old API tests to a new folder "Legacy".
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants