This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add tests for user-defined reductions extension #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec: intel/llvm#7202 Implementation: intel/llvm#7436
|
/verify with intel/llvm#7436 |
dm-vodopyanov
added a commit
to dm-vodopyanov/llvm
that referenced
this pull request
Nov 29, 2022
|
/verify with intel/llvm#7587 |
|
/verify with intel/llvm#7587 |
| assert(output[3] == std::reduce(input.begin(), input.end(), init, binary_op)); | ||
| } | ||
|
|
||
| int main() { |
There was a problem hiding this comment.
Please add a test with reduce over sub_group when one (or even several) WG(s) contain(s) several SGs. Might be done in another PR. The main thing I want is to use such a test as an example showing that even for reduce over SG the size of the temporary memory depends on WG size (unless we can allocate private memory for the scratchpad somehow and then use sg shuffles in the implementation).
aelovikov-intel
approved these changes
Nov 30, 2022
Comment on lines
+123
to
+124
| InputT *first = in.get_pointer(); | ||
| InputT *last = first + N; |
There was a problem hiding this comment.
Non-pointer iterators seem to be untested still.
dm-vodopyanov
added a commit
to intel/llvm
that referenced
this pull request
Dec 1, 2022
|
@dm-vodopyanov, new test fails on CUDA and HIP . Does it make sense disable it there? |
pvchupin
pushed a commit
to pvchupin/llvm-test-suite
that referenced
this pull request
Dec 1, 2022
Test was just added in intel#1395 and fails on these platforms
pvchupin
pushed a commit
that referenced
this pull request
Dec 1, 2022
Test was just added in #1395 and fails on these platforms
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Auto pulldown and update tc files for xmain-cand branch on 20221117
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…uite#1429) Test was just added in intel/llvm-test-suite#1395 and fails on these platforms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: intel/llvm#7202
Implementation: intel/llvm#7587