This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Separate ieee sqrt/div functions from ext_math.cpp test #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - separates the ieee_sqrt() and ieee_div() test cases to a new test, which is not started on Gen12 because it doesn't support those operations even for fp32. - enables ext_math.cpp on Windows. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
esimd_ieee_sqrt_div
branch
from
121598a to
4915287
Compare
kbobrovs
approved these changes
Nov 23, 2022
|
@pvchupin - I am trying to disable the test ext_math_ieee_sqrt_div.cpp on Tigerlake (aka Gen12 if I understand it correctly). Can you please recommend some better way to disable the test, or recommend someone who can give such recommendation? |
I don't remember who introduced these filters to LIT framework. You can try git blame. |
I believe |
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…l#1398) * [ESIMD] Separate ieee sqrt/div functions from ext_math.cpp test This patch: - separates the ieee_sqrt() and ieee_div() test cases to a new test, which is not started on Gen12 because it doesn't support those operations even for fp32. - enables ext_math.cpp on Windows. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…l/llvm-test-suite#1398) * [ESIMD] Separate ieee sqrt/div functions from ext_math.cpp test This patch: - separates the ieee_sqrt() and ieee_div() test cases to a new test, which is not started on Gen12 because it doesn't support those operations even for fp32. - enables ext_math.cpp on Windows. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Signed-off-by: Vyacheslav N Klochkov [email protected]