[SYCL][ESIMD] Introduce a test to validate correct processing of spirv global builtin calls #1431
Conversation
…bal builtin calls
fineg74
changed the title
| using namespace sycl; | ||
| using namespace sycl::ext::intel::esimd; | ||
|
|
||
| SYCL_EXTERNAL inline size_t __spirv_GlobalInvocationId_x() |
There was a problem hiding this comment.
IMO, if it is E2E test, then it should not use internal functions like these.
They can be replaced with 3 dimensional nd_range passed to kernel and get x,y,z dimensions by nd_item.get_global_id(dimension)
Otherwise, if it is not E2E test, it would be better to create a test accepting LLVM IR.
| for (auto Ind = 0; Ind < VL; ++Ind) { | ||
| A[I * VL + Ind] = __spirv_GlobalInvocationId_x(); | ||
| B[I * VL + Ind] = __spirv_GlobalInvocationId_y(); | ||
| C[I * VL + Ind] = __spirv_GlobalInvocationId_z(); |
There was a problem hiding this comment.
What __spirv_GlobalInvocationId_z() returns when the range is only 1 dimension?
There was a problem hiding this comment.
If it is 0 for _y, and 0 for _z, how do you know __spirv_GlobalInvocationId_z() is translated to something correct?, i.e. that it is not translated as if it was _y due to some error.
Please do not use internal functions. #1431 (comment)
|
No longer needed as global built in calls are no longer processed in sycl-post-link |
Complementary compiler PR intel/llvm#7590