This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix result check in joint matrix tests #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests in SYCL/Matrix verify their results but only use the results to print "passed" or "failed". A subset of these tests have checks for "passed" in the output, but does not use FileCheck to govern the check. This commit changes these tests to return a non-zero value in the main function if the result verification failed. This allows the test system to correctly identify tests that fail this verification. Signed-off-by: Larsen, Steffen <[email protected]>
againull
approved these changes
Dec 2, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Some tests in SYCL/Matrix verify their results but only use the results to print "passed" or "failed". A subset of these tests have checks for "passed" in the output, but does not use FileCheck to govern the check. This commit changes these tests to return a non-zero value in the main function if the result verification failed. This allows the test system to correctly identify tests that fail this verification. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…1432) Some tests in SYCL/Matrix verify their results but only use the results to print "passed" or "failed". A subset of these tests have checks for "passed" in the output, but does not use FileCheck to govern the check. This commit changes these tests to return a non-zero value in the main function if the result verification failed. This allows the test system to correctly identify tests that fail this verification. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in SYCL/Matrix verify their results but only use the results to print "passed" or "failed". A subset of these tests have checks for "passed" in the output, but does not use FileCheck to govern the check. This commit changes these tests to return a non-zero value in the main function if the result verification failed. This allows the test system to correctly identify tests that fail this verification.