Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Test bfloat16 fmax fmin #1444

Closed
wants to merge 4 commits into from
Closed

Conversation

jinge90
Copy link

@jinge90 jinge90 commented Dec 12, 2022

This PR is test for intel/llvm#7732

@jinge90
Copy link
Author

jinge90 commented Dec 13, 2022

/verify with intel/llvm#7732

@jinge90
Copy link
Author

jinge90 commented Dec 21, 2022

Hi, @pvchupin
Could you take a look at this PR? The pre-ci failed due to other issues:

[2022-12-21T01:55:54.907Z] terminate called after throwing an instance of 'sycl::_V1::runtime_error'

[2022-12-21T01:55:54.907Z] what(): No device of requested type available. -1 (PI_ERROR_DEVICE_NOT_FOUND)
Many unrelated test failed due to runtime error above.
Thanks very much.

@againull againull closed this Jan 4, 2023
@againull againull reopened this Jan 4, 2023
@JackAKirk
Copy link

There's some overlap here with https://github.com/intel/llvm-test-suite/blob/intel/SYCL/BFloat16/bfloat16_builtins.cpp, where fmin and fmax are also tested. The test was written when only the cuda backend was supported, but should now pass for all backends with the generic impls. Would it make sense to coalesce these two test files into a single file and enable it for all backends?
Thanks

@jinge90
Copy link
Author

jinge90 commented Jan 6, 2023

There's some overlap here with https://github.com/intel/llvm-test-suite/blob/intel/SYCL/BFloat16/bfloat16_builtins.cpp, where fmin and fmax are also tested. The test was written when only the cuda backend was supported, but should now pass for all backends with the generic impls. Would it make sense to coalesce these two test files into a single file and enable it for all backends? Thanks

I didn't realize that we have already had tests, it makes sense to coalesce these 2 test, I will do it soon.
Thanks very much.

@againull
Copy link

againull commented Jan 6, 2023

There's some overlap here with https://github.com/intel/llvm-test-suite/blob/intel/SYCL/BFloat16/bfloat16_builtins.cpp, where fmin and fmax are also tested. The test was written when only the cuda backend was supported, but should now pass for all backends with the generic impls. Would it make sense to coalesce these two test files into a single file and enable it for all backends? Thanks

I didn't realize that we have already had tests, it makes sense to coalesce these 2 test, I will do it soon. Thanks very much.

@jinge90 Thanks a lot! Do you prefer to get this PR merged and do coalescing in a separate PR? Or do you prefer to do coalescing in this PR?

@jinge90
Copy link
Author

jinge90 commented Jan 9, 2023

There's some overlap here with https://github.com/intel/llvm-test-suite/blob/intel/SYCL/BFloat16/bfloat16_builtins.cpp, where fmin and fmax are also tested. The test was written when only the cuda backend was supported, but should now pass for all backends with the generic impls. Would it make sense to coalesce these two test files into a single file and enable it for all backends? Thanks

I didn't realize that we have already had tests, it makes sense to coalesce these 2 test, I will do it soon. Thanks very much.

@jinge90 Thanks a lot! Do you prefer to get this PR merged and do coalescing in a separate PR? Or do you prefer to do coalescing in this PR?

Hi, @againull
I will close this PR and create a new one.
Thanks very much.

@jinge90 jinge90 closed this Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants