This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix kernel-bundle-merge-options-env.cpp #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
commented
Dec 13, 2022
| #include "kernel-bundle-merge-options.hpp" | ||
|
|
||
| // CHECK: piProgramBuild | ||
| // CHECK-NEXT: <unknown> | ||
| // CHECK-NEXT: <unknown> | ||
| // CHECK-NEXT: <unknown> | ||
| // CHECK-NEXT: <const char *>:{{.*}}-DENV_COMPILE_OPTS{{.*}}-vc-codegen | ||
| // CHECK: <const char *>:{{[^bar]*}}-DENV_COMPILE_OPTS{{[^bar]*}}-DENV_LINK_OPTS{{[^bar]*}} |
There was a problem hiding this comment.
Have not found a better way to check that the string contains one word and doesn't contain another.
v-klochkov
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
I am Ok with the fix.
Generally speaking adding -vc-codegen in our headers does not seem necessary because the same kernel type auto-detection mechanism should work (same as the one used in 'ocloc', which automatically detects the kernel type).
Right now though it is not a good moment experimenting with removal of insertion of 'vc-codegen' because there was a bug in GPU RT, which was fixed about 3 weeks ago and it will take some time before that newer GPU reaches CI.
|
The failures are unrelated. The same failures are here #1455 |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Calling link API is not supported for ESIMD kernels. Use simple kernel instead, as it is not important for the purpose of the test.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…#1445) Calling link API is not supported for ESIMD kernels. Use simple kernel instead, as it is not important for the purpose of the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling link API is not supported for ESIMD kernels. Use simple kernel instead, as it is not important for the purpose of the test.