-
Notifications
You must be signed in to change notification settings - Fork 130
[ESIMD] E2E test for slm_allocator API. #1449
Conversation
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see 2 non-blocking comments.
/verify with intel/llvm#7759 |
@kbobrovs - would you please create one more test case. Such difficult/complex changes in sycl-post-link deserve it, IMO. So, b() has 2 paths to it from kernel(). |
Yes, more tests will be added, including unit tests |
…slm_allocator. (#7759) This patch adds new class - slm_allocator - and its lowering. This is RAII-style class used to implement "semi-dynamic" SLM allocation. SLM is allocated in the constructor and released in the destructor, that's why it is "dynamic", as opposed to fully static allocation style of 'slm_init'. Actual offset of SLM chunk allocated by the call is calculated at compile time, that's why it is "semi-". To calculate SLM usage by a kernel, compiler finds a path in a callgraph with the largest amount of SLM "locked" by slm_allocator objects live along the paths. slm_init call also participates in calculating SLM budget. It can be modelled as slm_allocator object declared at the very beginning of a kernel and live till its the very end. Since a call graph is used, function pointers and recursion is not supported. Complementary E2E test: intel/llvm-test-suite#1449. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
dummy commit to restart testing
/verify |
The failed tests: accessor.cpp and UserDefinedReductions/user_defined_reductions_wg_size_larger_than_data_size.cpp are unrelated to the 3 tests being added by this PR. |
Thank you @kbobrovs for the changes and the test! |
use default python3 instead of '/usr/bin/python3' for atsm testing
* [ESIMD] E2E test for slm_allocator API. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
* [ESIMD] E2E test for slm_allocator API. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Complementary patch for intel/llvm#7759.
Signed-off-by: Konstantin S Bobrovsky [email protected]