This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Expand coverage of reqd_work_group_size tests #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reqd_work_group_size tests would previously only test for 3D kernels which were known to be the only dimensionality of the attribute to work as intended. Now that the attribute has been fixed we can extend this testing. Signed-off-by: Larsen, Steffen <[email protected]>
v-klochkov
reviewed
Dec 15, 2022
v-klochkov
reviewed
Dec 15, 2022
…nexpected cases Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
commented
Dec 16, 2022
| Q.wait_and_throw(); | ||
| std::cerr << TestCaseName << " failed: no exception has been thrown\n"; | ||
| return 1; // We shouldn't be here, exception is expected | ||
| } catch (nd_range_error &E) { |
There was a problem hiding this comment.
It should eventually be changed, but right now this is the exception we throw for this error case, so the test should be changed when we correct the behavior.
v-klochkov
approved these changes
Dec 16, 2022
Signed-off-by: Larsen, Steffen <[email protected]>
|
Using work-group size 8x8x8 exceeded the max size supported by the GPU backends which caused the L0 backend to return an error during kernel creation. All work sizes have been halved. |
|
Failures are in untouched files. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
The reqd_work_group_size tests would previously only test for 3D kernels which were known to be the only dimensionality of the attribute to work as intended. Now that the attribute has been fixed we can extend this testing. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-suite#1457) The reqd_work_group_size tests would previously only test for 3D kernels which were known to be the only dimensionality of the attribute to work as intended. Now that the attribute has been fixed we can extend this testing. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reqd_work_group_size tests would previously only test for 3D kernels which were known to be the only dimensionality of the attribute to work as intended. Now that the attribute has been fixed we can extend this testing.