Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL]Add check on subgroup size test to make sure its supported on platform #1466

Conversation

stdale-intel
Copy link

Guard lines in the test, so that we don't try to execute unsupported sub-group sizes on a device. Check the set of sub-group sizes that are supported on a device using the info::device::sub_group_sizes device descriptor

@stdale-intel stdale-intel requested a review from a team December 20, 2022 22:44
@stdale-intel stdale-intel changed the title Add check on subgroup size test to make sure its supported on platform [SYCL]Add check on subgroup size test to make sure its supported on platform Dec 21, 2022
@stdale-intel
Copy link
Author

Some pre-ci tests failing, but they are unrelated to my test which is passing
[2022-12-26T06:01:16.489Z] PASS: SYCL :: SubGroupMask/GroupSize.cpp (1069 of 1134)

Fails are unrelated:
FAIL: SYCL :: Plugin/level_zero_usm_device_read_only.cpp (908 of 1134) and other unrelated tests

should be ok to merge in once +1 from reviewers

Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@againull againull closed this Jan 4, 2023
@againull againull reopened this Jan 4, 2023
@againull
Copy link

againull commented Jan 4, 2023

Failure:
SYCL :: SubGroupMask/Basic.cpp
is known and tracked.

@againull againull merged commit 4d1861b into intel:intel Jan 4, 2023
@stdale-intel stdale-intel deleted the private/stewartt/subGroupTestSupportedSizeCheck branch January 5, 2023 00:11
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
[SYCL]Add check on subgroup size test to make sure its supported on platform (intel#1466)
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants