Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] use per_kernel split mode for the test SYCL/SubGroupMask/GroupSize.cpp #1472

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[SYCL] use per_kernel split mode for the test SYCL/SubGroupMask/GroupSize.cpp #1472

merged 1 commit into from
Jan 5, 2023

Conversation

myler
Copy link

@myler myler commented Dec 25, 2022

No description provided.

@myler myler requested review from Pennycook and a team as code owners December 25, 2022 14:43
@myler myler requested a review from bso-intel December 25, 2022 14:43
@myler
Copy link
Author

myler commented Dec 25, 2022

Tagging @AlexeySachkov
Automatic split based on reqd-sub-group-size is not available yet, this PR is to add -fsycl-device-code-split=per_kernel

@myler
Copy link
Author

myler commented Dec 26, 2022

pre-ci-windows testing got massive failures:

[2022-12-25T17:01:21.615Z] Testing Time: 1786.16s
[2022-12-25T17:01:21.615Z]   Unsupported      : 455
[2022-12-25T17:01:21.615Z]   Passed           :  62
[2022-12-25T17:01:21.615Z]   Expectedly Failed:  11
[2022-12-25T17:01:21.615Z]   Failed           : 606

pre-ci-linux testing failed at Check-env Step

@myler
Copy link
Author

myler commented Dec 27, 2022

Unrelated failure

[2022-12-27T01:43:38.880Z]   SYCL :: Config/select_device.cpp

@myler
Copy link
Author

myler commented Jan 3, 2023

Unrelated failure

[2023-01-03T01:29:18.896Z]   SYCL :: Config/select_device.cpp

[2023-01-03T01:54:33.809Z] Failed Tests (3):
[2023-01-03T01:54:33.809Z]   SYCL :: Config/select_device.cpp
[2023-01-03T01:54:33.809Z]   SYCL :: DeviceArchitecture/device_architecture.cpp
[2023-01-03T01:54:33.809Z]   SYCL :: SubGroupMask/Basic.cpp

This PR related test is passed.

[2023-01-03T01:51:42.581Z] PASS: SYCL :: SubGroupMask/GroupSize.cpp (1067 of 1133)

[2023-01-03T01:27:37.293Z] PASS: SYCL :: SubGroupMask/GroupSize.cpp (1067 of 1133)

@intel/llvm-reviewers-runtime @Pennycook may I ask you to merge this PR?

Pennycook
Pennycook approved these changes Jan 4, 2023
View reviewed changes
Copy link

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't merge, but changes LGTM.

@AlexeySachkov AlexeySachkov merged commit 623d110 into intel:intel Jan 5, 2023
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@myler
[SYCL] use per_kernel split mode for the test SYCL/SubGroupMask/Group…
e361eff 
…Size.cpp (intel#1472)
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@myler
Merge pull request intel#1522 from myler/CMPLRTST-18880
637f75a 
[SYCL] use per_kernel split mode for the test SYCL/SubGroupMask/GroupSize.cpp (intel#1472)
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@myler
[SYCL] use per_kernel split mode for the test SYCL/SubGroupMask/Group…
a92b1eb 
…Size.cpp (intel/llvm-test-suite#1472)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pennycook Pennycook Pennycook approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myler @Pennycook @AlexeySachkov