Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL]Use Subgroup size 16 as default for InlineASM tests #1476

Merged

Conversation

stdale-intel
Copy link

Since sgsize = 8 is not supported on all platforms, this PR use sgsize = 16 instead as it is common across gpu platforms for tests not specifically testing a given sgsize (ie.. asm_8_, asm_16_,malloc_shared_32)

… as default subgroup size unless specifically testing a given size (8 or 32 for example in some tests)
@stdale-intel stdale-intel requested a review from a team as a code owner December 29, 2022 06:52
@stdale-intel stdale-intel marked this pull request as draft December 29, 2022 06:52
@stdale-intel stdale-intel marked this pull request as ready for review January 4, 2023 04:51
@againull
Copy link

againull commented Jan 4, 2023

Failure:
SYCL :: SubGroupMask/Basic.cpp
is known and tracked.

@againull againull merged commit 417b60f into intel:intel Jan 4, 2023
@stdale-intel stdale-intel deleted the private/stewartt/noSIMD8InlineASM branch January 4, 2023 20:35
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Subgroup size 8 is not supported on all gpu platforms. Instead use 16 as default subgroup size unless specifically testing a given size (8 or 32 for example in some tests).
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…m-test-suite#1476)

Subgroup size 8 is not supported on all gpu platforms. Instead use 16 as default subgroup size unless specifically testing a given size (8 or 32 for example in some tests).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants