This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Do not use cl_* types in some tests #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl_* types are defined by SYCL spec as interoperability interface with OpenCL. There is no need to use them in most of SYCL tests. This change is mostly motivated by the fact that those cl_* type aliases were moved from `sycl` into `sycl::opencl` namespace: we simply want to avoid tests breakage when we align the implementation with the spec.
|
@intel/dpcpp-tools-reviewers, @intel/llvm-reviewers-runtime, could you please take a look at this PR? |
aelovikov-intel
approved these changes
Jan 27, 2023
sarnex
approved these changes
Jan 27, 2023
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
`cl_*` types are defined by SYCL spec as interoperability interface with OpenCL. There is no need to use them in most of SYCL tests. This change is mostly motivated by the fact that those `cl_*` type aliases were moved from `sycl` into `sycl::opencl` namespace: we simply want to avoid tests breakage when we align the implementation with the spec.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
`cl_*` types are defined by SYCL spec as interoperability interface with OpenCL. There is no need to use them in most of SYCL tests. This change is mostly motivated by the fact that those `cl_*` type aliases were moved from `sycl` into `sycl::opencl` namespace: we simply want to avoid tests breakage when we align the implementation with the spec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl_* types are defined by SYCL spec as interoperability interface with OpenCL. There is no need to use them in most of SYCL tests.
This change is mostly motivated by the fact that those cl_* type aliases were moved from
syclintosycl::openclnamespace: we simply want to avoid tests breakage when we align the implementation with the spec.