[SYCL][ESIMD] Add test for kernel defined in template function

[sarnex]

Related to intel/llvm#7996

Signed-off-by: Sarnie, Nick [email protected]

[sarnex]

/verify with intel/llvm#7996

[v-klochkov]

Thank you for the test.
I have only 2 comments:

• PR needs clang-format fix

• Not a requirement to change now, but a notice worse mentioning:
  If you have equal choice between using USM or BUFFERs, then please choose USM because GPU RT is going to drop support of stateful accesses soon; buffers/acc API should still be supported, but via some emulation method (acc.get_pointer() + stateless GenX intrin).

[sarnex]

@v-klochkov Thanks!

The clang-format looks wrong acutally, it's breaking a comment:

diff --git a/SYCL/ESIMD/template.cpp b/SYCL/ESIMD/template.cpp
index 2a20ebe4..24ab5e98 100644
--- a/SYCL/ESIMD/template.cpp
+++ b/SYCL/ESIMD/template.cpp
@@ -1,4 +1,5 @@
-//==---------------- template.cpp  - DPC++ ESIMD on-device test -------------==//
+//==---------------- template.cpp  - DPC++ ESIMD on-device test
+//-------------==//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.

I just modified vadd_1d.cpp instead of writing this myself, so I'll just leave it for now

[v-klochkov]

d_1d.cpp instead of writing this myself, so I'll just l

I think making the line 1 symbol shorter would solve the problem with clang-format

[sarnex]

I think making the line 1 symbol shorter would solve the problem with clang-format

ah ok let me try thanks

[v-klochkov]

@v-klochkov Thanks!

The clang-format looks wrong acutally, it's breaking a comment:

diff --git a/SYCL/ESIMD/template.cpp b/SYCL/ESIMD/template.cpp
index 2a20ebe4..24ab5e98 100644
--- a/SYCL/ESIMD/template.cpp
+++ b/SYCL/ESIMD/template.cpp
@@ -1,4 +1,5 @@
-//==---------------- template.cpp  - DPC++ ESIMD on-device test -------------==//
+//==---------------- template.cpp  - DPC++ ESIMD on-device test
+//-------------==//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.

I just modified vadd_1d.cpp instead of writing this myself, so I'll just leave it for now

Please keep this test as a separate one. vadd_1d.cpp is known as one of most trivial tests that always worked and perhaps will.

[sarnex]

Please keep this test as a separate one. vadd_1d.cpp is known as one of most trivial tests that always worked and perhaps will.

Sorry, I mean this test is based on that one. That file is not modified.

[v-klochkov]

/verify with intel/llvm#7996

[v-klochkov]

@sarnex - please click 'Ready for review' when you think it is ready.

[sarnex]

@v-klochkov Done, whoops

[v-klochkov]

The new test expectedly failed without the fix in ESIMD headers and passed with it (Jenkins/llvm-test-suite)
Merging now.