Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add test for sycl::is_compatible supports reqd_work_group_size #1528

Conversation

dm-vodopyanov
Copy link

@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner January 19, 2023 17:19
@dm-vodopyanov
Copy link
Author

/verify with intel/llvm#8056

@dm-vodopyanov
Copy link
Author

/verify with intel/llvm#8056

@dm-vodopyanov
Copy link
Author

@intel/llvm-reviewers-runtime , @cperkinsintel , friendly ping

@dm-vodopyanov
Copy link
Author

@intel/llvm-reviewers-runtime , can you please review this?

dm-vodopyanov added a commit to intel/llvm that referenced this pull request Jan 27, 2023
…roup-size (#8056)

This patch implements device code split based on reqd-work-group-size
attribute, enables generation of "reqd_work_group_size" property in
"SYCL/device requirements" property set, and adds support of
reqd-work-group-size to sycl::is_compatible

Design:

https://github.com/intel/llvm/blob/sycl/sycl/doc/design/OptionalDeviceFeatures.md#changes-to-the-device-code-split-algorithm
E2E tests: intel/llvm-test-suite#1528
Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please make clang-format happy? 😄

@dm-vodopyanov
Copy link
Author

LGTM! Could you please make clang-format happy? 😄

Oh yes, sure, fixed.

@dm-vodopyanov dm-vodopyanov merged commit 4c8ccf4 into intel:intel Jan 27, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
[SYCL][Matrix] minor correction in legacy bfloat16 test
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants