This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Add test for sycl::is_compatible supports reqd_work_group_size #1528
Merged
dm-vodopyanov
merged 3 commits into
intel:intel
from
dm-vodopyanov:test-is_compatible-supports-reqd-wg-size
Jan 27, 2023
Merged
[SYCL] Add test for sycl::is_compatible supports reqd_work_group_size #1528
dm-vodopyanov
merged 3 commits into
intel:intel
from
dm-vodopyanov:test-is_compatible-supports-reqd-wg-size
Jan 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/verify with intel/llvm#8056 |
/verify with intel/llvm#8056 |
@intel/llvm-reviewers-runtime , @cperkinsintel , friendly ping |
@intel/llvm-reviewers-runtime , can you please review this? |
dm-vodopyanov
added a commit
to intel/llvm
that referenced
this pull request
Jan 27, 2023
…roup-size (#8056) This patch implements device code split based on reqd-work-group-size attribute, enables generation of "reqd_work_group_size" property in "SYCL/device requirements" property set, and adds support of reqd-work-group-size to sycl::is_compatible Design: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/OptionalDeviceFeatures.md#changes-to-the-device-code-split-algorithm E2E tests: intel/llvm-test-suite#1528
steffenlarsen
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you please make clang-format happy? 😄
Oh yes, sure, fixed. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
[SYCL][Matrix] minor correction in legacy bfloat16 test
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl: intel/llvm#8056