This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Update sycl complex testing #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Mar 10, 2023
This PR updates the complex implementation. From the POV of the complex's user, the interface does not change. The modification made to the implementation are: - the operators are now declared as hidden friends - encapsulation of helper functions of the implementation (only expose what needs to be) - using metaprogramming to specialize the complex when the trait `is_genfloat` is true, which removes the duplication of the operators - using metaprogramming to specialize different math operations when the trait `is_genfloat` is true, which removes some boilerplate code - add the missing `inline` attribute to different functions - remove unnecessary const and ref keywords on `value_type` - add missing `std::enable_if` on free functions llvm-test-suite: intel/llvm-test-suite#1533
againull
approved these changes
Mar 11, 2023
|
Now that intel/llvm#8068 got merged, I was hoping we could merge this too. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
This PR updates the tests for the experimental sycl complex implementation. It tests the new unary operators `+` and `-`, the new functions `real` and `imag` and the variant of `conj`, `proj`, `arg`, `norm`, when the function is called with decimals as arguments. An overload of `test_valid_types` which takes a template template parameter that takes two typename parameters has been introduced to support the new `deci_test_cases`. Finally, the `test_cases` structure has been renamed to `cplx_test_cases` to be coherent with the new `deci_test_cases`. Depends on: intel/llvm#8068
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
This PR updates the tests for the experimental sycl complex implementation. It tests the new unary operators `+` and `-`, the new functions `real` and `imag` and the variant of `conj`, `proj`, `arg`, `norm`, when the function is called with decimals as arguments. An overload of `test_valid_types` which takes a template template parameter that takes two typename parameters has been introduced to support the new `deci_test_cases`. Finally, the `test_cases` structure has been renamed to `cplx_test_cases` to be coherent with the new `deci_test_cases`. Depends on: intel#8068
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tests for the experimental sycl complex implementation.
It tests the new unary operators
+and-, the new functionsrealandimagand the variant ofconj,proj,arg,norm, when the function is called with decimals as arguments.An overload of
test_valid_typeswhich takes a template template parameter that takes two typename parameters has been introduced to support the newdeci_test_cases.Finally, the
test_casesstructure has been renamed tocplx_test_casesto be coherent with the newdeci_test_cases.Depends on: intel/llvm#8068