Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Extends placeholder accessor tests #1549

Merged

Conversation

maarquitos14
Copy link

Prior to this change there were some subtleties that made us throw the wrong exception or even don't throw an exception in cases were we should. These changes include tests for those cases.

Prior to this change there were some subtleties that made us
throw the wrong exception or even don't throw an exception in cases
were we should. These changes include tests for those cases.
Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but otherwise LGTM!

@steffenlarsen
Copy link

Failed Tests (2):
SYCL :: KernelFusion/abort_fusion.cpp
SYCL :: KernelFusion/abort_internalization.cpp

These are unrelated and should be due to desync between intel/llvm and intel/llvm-test-suite.

@steffenlarsen steffenlarsen merged commit d366158 into intel:intel Feb 15, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Remove XFAIL from element_wise_all_ops_bf16 since the fixes of CMPLRLLVM-43327 are landed
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Prior to this change there were some subtleties that made us
throw the wrong exception or even don't throw an exception in cases
were we should. These changes include tests for those cases.

---------

Signed-off-by: Maronas, Marcos <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Prior to this change there were some subtleties that made us
throw the wrong exception or even don't throw an exception in cases
were we should. These changes include tests for those cases.

---------

Signed-off-by: Maronas, Marcos <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants