This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Extends placeholder accessor tests #1549
Merged
steffenlarsen
merged 6 commits into
intel:intel
from
maarquitos14:maronas/placeholder-accessor-tests
Feb 15, 2023
Merged
[SYCL] Extends placeholder accessor tests #1549
steffenlarsen
merged 6 commits into
intel:intel
from
maarquitos14:maronas/placeholder-accessor-tests
Feb 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change there were some subtleties that made us throw the wrong exception or even don't throw an exception in cases were we should. These changes include tests for those cases.
steffenlarsen
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but otherwise LGTM!
Signed-off-by: Maronas, Marcos <[email protected]>
…older-accessor-tests
steffenlarsen
approved these changes
Jan 30, 2023
Failed Tests (2): These are unrelated and should be due to desync between intel/llvm and intel/llvm-test-suite. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Remove XFAIL from element_wise_all_ops_bf16 since the fixes of CMPLRLLVM-43327 are landed
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Prior to this change there were some subtleties that made us throw the wrong exception or even don't throw an exception in cases were we should. These changes include tests for those cases. --------- Signed-off-by: Maronas, Marcos <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Prior to this change there were some subtleties that made us throw the wrong exception or even don't throw an exception in cases were we should. These changes include tests for those cases. --------- Signed-off-by: Maronas, Marcos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change there were some subtleties that made us throw the wrong exception or even don't throw an exception in cases were we should. These changes include tests for those cases.