This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Do not use cl_* types in DeviceLib tests
#1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cl_*` types are only defined by SYCL 2020 spec for interoperability with OpenCL backend. We should be focusing on core SYCL types instead.
| s::queue myQueue; | ||
| myQueue.submit([&](s::handler &cgh) { | ||
| auto AccR = BufR.get_access<s::access::mode::write>(cgh); | ||
| cgh.single_task<class rotateSI1SI2>([=]() { | ||
| AccR[0] = s::rotate(static_cast<s::cl_char>((unsigned char)0xe0), | ||
| s::cl_char{50}); | ||
| AccR[0] = s::rotate((unsigned char)0xe0, (unsigned char)50); |
There was a problem hiding this comment.
not sure if it is important but arguments on the left is finally char, not unsigned ones
There was a problem hiding this comment.
Let's try to keep the test as close as possible to the original version, changed this line in 57be286
KseniyaTikhomirova
approved these changes
Jan 30, 2023
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
`cl_*` types are only defined by SYCL 2020 spec for interoperability with OpenCL backend. We should be focusing on core SYCL types instead.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ite#1555) `cl_*` types are only defined by SYCL 2020 spec for interoperability with OpenCL backend. We should be focusing on core SYCL types instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl_*types are only defined by SYCL 2020 spec for interoperability with OpenCL backend. We should be focusing on core SYCL types instead.