Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Add 'regression' tests to SYCL/InvokeSimd #1561

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Add 'regression' tests to SYCL/InvokeSimd #1561

merged 6 commits into from
Feb 1, 2023

Conversation

fveselov
Copy link

'Regression' category tests

@fveselov fveselov requested a review from a team as a code owner January 31, 2023 10:05
@sarnex
Copy link

sarnex commented Jan 31, 2023

LGTM, we can merge once CI passes :)

Copy link

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked through this huge PR. It looks good to me. Thanks to @sarnex for being main reviewer of this PR.

Maybe just one question that can be fixed easily.
The folder names used in InvokeSimd folder use 3 different styles:

  • SomeFolder // GOOD // e.g. 'InvokeSimd'
  • something // Ok // e.g. 'regression'. IMO 'Regression would be more consistent, but Ok.
  • SOME_FOLDER // not Ok, IMO // e.g. 'IMPL_SUBGROUP'. Can it be renamed to 'ImplicitSubgroup', please?

@v-klochkov v-klochkov changed the title Add 'regression' tests to InvokeSimd Add 'regression' tests to SYCL/InvokeSimd Feb 1, 2023
renamed tests directory with respect to naming convention
@fveselov
Copy link
Author

fveselov commented Feb 1, 2023

I have looked through this huge PR. It looks good to me. Thanks to @sarnex for being main reviewer of this PR.

Maybe just one question that can be fixed easily. The folder names used in InvokeSimd folder use 3 different styles:

  • SomeFolder // GOOD // e.g. 'InvokeSimd'
  • something // Ok // e.g. 'regression'. IMO 'Regression would be more consistent, but Ok.
  • SOME_FOLDER // not Ok, IMO // e.g. 'IMPL_SUBGROUP'. Can it be renamed to 'ImplicitSubgroup', please?

Agree, renamed both 'regression' and 'IMPL_SUBGROUP' directories.

I also created one more PR (#1562) doing a similar renames for the "Feature" and "Spec" categories of InvokeSimd.

@fveselov
Copy link
Author

fveselov commented Feb 1, 2023

Windows and Linux CIs failures are unrelated to changes:

[2023-02-01T10:35:43.252Z] Failed Tests (3):
[2023-02-01T10:35:43.252Z] SYCL :: ESIMD/api/svm_gather_scatter_scalar_off.cpp
[2023-02-01T10:35:43.252Z] SYCL :: ESIMD/dword_atomic_cmpxchg_scalar_off.cpp
[2023-02-01T10:35:43.252Z] SYCL :: ESIMD/dword_atomic_smoke_scalar_off.cpp

@v-klochkov
Copy link

v-klochkov commented Feb 1, 2023

Windows and Linux CIs failures are unrelated to changes:

[2023-02-01T10:35:43.252Z] Failed Tests (3):
[2023-02-01T10:35:43.252Z] SYCL :: ESIMD/api/svm_gather_scatter_scalar_off.cpp
[2023-02-01T10:35:43.252Z] SYCL :: ESIMD/dword_atomic_cmpxchg_scalar_off.cpp
[2023-02-01T10:35:43.252Z] SYCL :: ESIMD/dword_atomic_smoke_scalar_off.cpp

@fineg74 - please take a look at these fails, they must be caused by one of your recent changes in these tests.
Well, it also possible that the fails showed up because the older/yesterday version of compiler was used to run this llvm-test-suite changes.

@v-klochkov v-klochkov merged commit 32e8731 into intel:intel Feb 1, 2023
@fveselov fveselov deleted the invoke_simd_regression branch February 1, 2023 18:04
@fineg74
Copy link

fineg74 commented Feb 1, 2023

@v-klochkov It seems the compiler change for scalar offset didn't go into latest nightly build for some reason that is used to run tests. The latest commit that went into nightly build was 8:23 AM commit while scalar offset change was merged at 15:35
Will follow up tomorrow if the problem persists

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants