-
Notifications
You must be signed in to change notification settings - Fork 130
Add 'regression' tests to SYCL/InvokeSimd #1561
Conversation
SYCL/InvokeSimd/regression/matrix_multiply_accessor_get_pointer.cpp
Outdated
Show resolved
Hide resolved
LGTM, we can merge once CI passes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked through this huge PR. It looks good to me. Thanks to @sarnex for being main reviewer of this PR.
Maybe just one question that can be fixed easily.
The folder names used in InvokeSimd folder use 3 different styles:
- SomeFolder // GOOD // e.g. 'InvokeSimd'
- something // Ok // e.g. 'regression'. IMO 'Regression would be more consistent, but Ok.
- SOME_FOLDER // not Ok, IMO // e.g. 'IMPL_SUBGROUP'. Can it be renamed to 'ImplicitSubgroup', please?
renamed tests directory with respect to naming convention
Agree, renamed both 'regression' and 'IMPL_SUBGROUP' directories. I also created one more PR (#1562) doing a similar renames for the "Feature" and "Spec" categories of InvokeSimd. |
Windows and Linux CIs failures are unrelated to changes:
|
@fineg74 - please take a look at these fails, they must be caused by one of your recent changes in these tests. |
@v-klochkov It seems the compiler change for scalar offset didn't go into latest nightly build for some reason that is used to run tests. The latest commit that went into nightly build was 8:23 AM commit while scalar offset change was merged at 15:35 |
'Regression' category tests