Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][Fusion] Add missing event waits #1563

Merged

Conversation

sommerlukas
Copy link

Add missing event::wait for the event returned by queue::submit while in fusion mode.

The event returned from queue::submit is associated with the internal placeholder command. It depends on the event returned by complete_fusion, but is not identical to it, so an additional wait is required in the tests to avoid the assert to fail.

@sommerlukas sommerlukas requested a review from a team as a code owner February 1, 2023 15:53
@sommerlukas sommerlukas self-assigned this Feb 1, 2023
@sommerlukas
Copy link
Author

This should fix the failures encountered in #1554.

@sommerlukas
Copy link
Author

The following tests failed in the pipeline:

Failed Tests (3):
SYCL :: ESIMD/api/svm_gather_scatter_scalar_off.cpp
SYCL :: ESIMD/dword_atomic_cmpxchg_scalar_off.cpp
SYCL :: ESIMD/dword_atomic_smoke_scalar_off.cpp

These should be unrelated to this PR.

@steffenlarsen: I couldn't find a matching issue/PR, should I report this?

@steffenlarsen
Copy link

Given the failures are compiler errors in untouched tests that don't show up in newer PRs, I have a suspicion this is just a test-change ahead of a new nightly coming in, so let us merge this without an issue and see if it pops up again later.

@steffenlarsen steffenlarsen merged commit 3b9ed17 into intel:intel Feb 2, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants