This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix memory leak in slm_alloc.cpp #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It missed free() call.
fineg74
reviewed
Feb 2, 2023
SYCL/ESIMD/slm_alloc.cpp
Outdated
| @@ -1,7 +1,6 @@ | |||
| // REQUIRES: gpu | |||
| // UNSUPPORTED: cuda || hip || esimd_emulator | |||
| // | |||
| // RUN: %clangxx -fsycl %s -o %t.1.out | |||
There was a problem hiding this comment.
What is the reason for removal of this line ?
There was a problem hiding this comment.
That's a mistake. I recovered that line.
Thanks.
Signed-off-by: Byoungro So <[email protected]>
v-klochkov
approved these changes
Feb 2, 2023
fineg74
approved these changes
Feb 2, 2023
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
* [SYCL] Fix memory leak in slm_alloc.cpp Signed-off-by: Byoungro So <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [SYCL] Fix memory leak in slm_alloc.cpp Signed-off-by: Byoungro So <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It missed free() call.