Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Add test for general bf16 isnan impl #1568

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jinge90
Copy link

@jinge90 jinge90 commented Feb 2, 2023

Re-submit #1509 . Previously, this patch led to CUDA backend pre-commit failure, the root cause is a typo in patch, the new PR has fixed the typo and tested on CUDA backend.

@jinge90 jinge90 requested a review from a team as a code owner February 2, 2023 08:28
@jinge90
Copy link
Author

jinge90 commented Feb 2, 2023

Hi, @bader and @aelovikov-intel
I found the root cause of intel/llvm#8040 and fixed it this PR.
Thanks very much.

@aelovikov-intel
Copy link

I found the root cause of intel/llvm#8040 and fixed it this PR

What was it?

@jinge90
Copy link
Author

jinge90 commented Feb 3, 2023

I found the root cause of intel/llvm#8040 and fixed it this PR

What was it?

The error code is set when function "check" returns true(https://github.com/intel/llvm-test-suite/blob/intel/SYCL/BFloat16/bfloat16_builtins.cpp#L41) which means "check" should return true when result and reference value doesn't math. The corrected version should be:
bool check(bool a, bool b) { return (a != b); }

Previously, the code is
bool check(bool a, bool b) { return (a == b); }

@GeorgeWeb
Copy link

Hi @jinge90, we were looking into this too and we're pleased to see this patch.

@jinge90
Copy link
Author

jinge90 commented Feb 16, 2023

Hi, @intel/dpcpp-tools-reviewers
Could you help review this PR?
Thanks very much.

@GeorgeWeb
Copy link

Hi @intel/dpcpp-tools-reviewers / @AlexeySachkov 👋. Would it be possible to review and merge this?
Thank youi!

Copy link

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No merge permission though, sorry :)

@AlexeySachkov AlexeySachkov merged commit ae62107 into intel:intel Mar 1, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants