This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] [L0] Specify standard command lists explicitly when the test depends on it. #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It's a draft now, so cannot approve. |
rdeodhar
changed the title
smaslov-intel
approved these changes
Feb 10, 2023
|
This is ready for merge. On both Linux and Windows the same test failed, Reduction/reduction_ctor.cpp, which cannot be a result of this PR because this PR modifies different tests. |
|
/verify with intel/llvm#7196 |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…epends on it. (intel#1585) * Make use of standard command lists explicit, when the test depends on it. * Extended a test to work with imm cmdlists.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…epends on it. (intel/llvm-test-suite#1585) * Make use of standard command lists explicit, when the test depends on it. * Extended a test to work with imm cmdlists.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the tests is in preparation of making use of immediate command lists the default on all GPUs. Some tests depend on use of standard command lists, so make it explicit that that type of command list should be used by the test.