This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Added E2E test for kernel_bundle::get_kernel<KernelName>() #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm#8294 |
|
/verify with intel/llvm#8294 |
AlexeySachkov
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 24, 2023
`kernel_bundle` was missing the `template <typename KernelName> kernel get_kernel() const;` from its complete list of queries from the spec [4.11.12.1](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:bundles.query). This patch implements this missing function. An E2E test was required in order to test this, the test for this patch is intel/llvm-test-suite#1589.
added 2 commits
February 24, 2023 06:12
Small issue with returned value of expected attribute string, so replacing with context comparison. Now passes on level_zero also.
|
The implementation of this has now been merged as part of intel/llvm#8294 |
added 2 commits
March 7, 2023 06:29
Just relying on the actual get_info calls themselves for equality comparison.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the test to ensure the functionality of the
template <typename KernelName> kernel get_kernel() constfunction that was added in patch intel/llvm#8294An E2E test was required to ensure the correct information was present to compare and test the kernels against one another via
get_info, asoperator==isn't guaranteed to work in this instance.