This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][Fusion] Test non-internalization if the pointer is stored #1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommerlukas
reviewed
Feb 16, 2023
victor-eds
force-pushed
the
abort-intern-if-stored-ptr
branch
from
504543e to
29f5289
Compare
sommerlukas
approved these changes
Mar 9, 2023
|
@intel/llvm-gatekeepers can I get this one merged? |
steffenlarsen
approved these changes
Mar 17, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…el/llvm-test-suite#1600) Test internalization is not performed when the argument to be internalized is stored. The new `abort_internalization_stored_ptr.cpp` passes an `accessor` holding the input pointer to a `noinline` function, thus forcing the input pointer argument to be stored in an `accessor` struct being passed to such function. --------- Signed-off-by: Victor Perez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test internalization is not performed when the argument to be internalized is stored.
The new
abort_internalization_stored_ptr.cpppasses anaccessorholding the input pointer to anoinlinefunction, thus forcing the input pointer argument to be stored in anaccessorstruct being passed to such function.