Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][Fusion] Explicitly initialize vec in different_nd_ranges test #1623

Conversation

victor-eds
Copy link

Explicitly initialize vec to ensure all components are zero-initialied.

This fixes failures when passing -O0 to the tests.

Explicitly initialize vec to ensure all components are
zero-initialied.

Signed-off-by: Victor Perez <[email protected]>
@victor-eds victor-eds requested a review from a team as a code owner February 28, 2023 13:12
@victor-eds victor-eds requested a review from againull February 28, 2023 13:12
@victor-eds victor-eds self-assigned this Feb 28, 2023
@victor-eds
Copy link
Author

@dm-vodopyanov can I get this one merged?

@dm-vodopyanov
Copy link

@victor-eds, yes, it can be merged now. Usually patches are merged by people from @intel/llvm-gatekeepers within 1-2 business days, so pinging is not required, unless it is a critical PR which should be merged immediately, but if you see your patch isn't merged after a few days, please ping @intel/llvm-gatekeepers

@dm-vodopyanov dm-vodopyanov merged commit 6305c41 into intel:intel Mar 6, 2023
@victor-eds victor-eds deleted the kernel-fusion/explicitly-initialize-vec branch March 6, 2023 15:28
@victor-eds
Copy link
Author

@victor-eds, yes, it can be merged now. Usually patches are merged by people from @intel/llvm-gatekeepers within 1-2 business days, so pinging is not required, unless it is a critical PR which should be merged immediately, but if you see your patch isn't merged after a few days, please ping @intel/llvm-gatekeepers

Thanks, I wasn't aware @intel/llvm-gatekeepers also applied to this repo. I'll do as proposed in the future.

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
…ntel#1623)

Explicitly initialize vec to ensure all components are
zero-initialied.

Signed-off-by: Victor Perez <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…ntel/llvm-test-suite#1623)

Explicitly initialize vec to ensure all components are
zero-initialied.

Signed-off-by: Victor Perez <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants