[SYCL][ESIMD] Enable invoke_simd simd_mask test #1630
Conversation
|
/verify with intel/llvm#8524 |
|
Failure is as expected as it required intel/llvm change |
|
/verify with intel/llvm#8524 |
|
@sarnex - please take a look at this fail: http://llvm-ci2.intel.com:8080/job/SYCL_CI/job/intel/job/LLVM_Test_Suite_Associate_CI/536/display/redirect It fails at compile time due to tuple_for_each() |
|
@v-klochkov ah ok thanks, namespace problem
|
|
/verify with intel/llvm#8524 |
|
@sarnex - Jenkins/llvm-test-suite failed catastrophically. Can you please do 'git merge' to this PR (and may-be the PR in ESIMD headers as well) to restart it? |
Add tests for all valid simd_mask types and the boolean conversion to/from them. Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
|
done, lets hope it works this time |
|
/verify with intel/llvm#8524 |
1 similar comment
|
/verify with intel/llvm#8524 |
It seems sometimes (often?) such command is ignored. The first one was ignored this time. |
Signed-off-by: Sarnie, Nick <[email protected]>
weird, thanks. |
|
/verify with intel/llvm#8524 |
|
@v-klochkov I found with /verify with doeesn't work for me, I'm missing permissions, I'll try to get it fixed. Ping me offline if you're interested |
|
/verify with intel/llvm#8524 |
) As per our recent discussions, bool passed into invoke_simd should convert to simd_mask with a user-defined type. Conversely, simd_mask will convert back to bool from inside the invoked function. I also had to fix a couple of minor bugs in the implementation of the DPCPP-specific changes in std::experimental::simd. I will make a follow-up PR to update the invoke_simd spec with the results of our recent discussion. Test PR: intel/llvm-test-suite#1630 --------- Signed-off-by: Sarnie, Nick <[email protected]>
* [SYCL][ESIMD] Enable invoke_simd simd_mask test Add tests for all valid simd_mask types and the boolean conversion to/from them. Signed-off-by: Sarnie, Nick <[email protected]>
…e#1630) * [SYCL][ESIMD] Enable invoke_simd simd_mask test Add tests for all valid simd_mask types and the boolean conversion to/from them. Signed-off-by: Sarnie, Nick <[email protected]>
Add tests for all valid simd_mask types and the boolean conversion to/from them.
Main PR: intel/llvm#8524