This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add identityless reduction test cases #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds test cases to existing tests for testing reductions where the identity is unspecified and unknown. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
|
/verify with intel/llvm#8562 |
Comment on lines
15
to
18
| template <typename Name, typename T, class BinaryOperation> | ||
| void tests(queue &Q, T Identity, T Init, BinaryOperation BOp, range<1> Range) { | ||
| NumErrors += test<Name>(Q, Identity, Init, BOp, Range); | ||
| } |
There was a problem hiding this comment.
nit, if possible:
template <typename Name, typename... ArgTys>
void tests(ArgTys &&Args) {
NumErrors += test<Name>(std::forward<ArgTys>(Args)...);
}
Same in other places.
| @@ -48,6 +53,22 @@ int main() { | |||
|
|
|||
| tests<class C1>(Q, CustomVec<long long>(0), CustomVec<long long>(99), | |||
| CustomVecPlus<long long>{}, range<2>{33, MaxWGSize}); | |||
| tests<class C2>(Q, CustomVec<long long>(99), CustomVecPlus<long long>{}, | |||
There was a problem hiding this comment.
Do we really need to keep the one with the identity param? Especially given the new test cases below to test that path.
There was a problem hiding this comment.
I think it makes sense to test for custom types to make sure that runtime identities also work correctly for custom types.
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
approved these changes
Mar 8, 2023
|
/verify with intel/llvm#8562 |
1 similar comment
|
/verify with intel/llvm#8562 |
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
|
Some test cases are disabled temporarily due to a known bug in reductions. A patch for this will follow after intel/llvm#8562. |
|
Verified with intel/llvm#8562. |
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Auto pulldown and update tc files for xmain-cand branch on 20230313
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
This commit adds test cases to existing tests for testing reductions where the identity is unspecified and unknown. --------- Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
) This commit adds test cases to existing tests for testing reductions where the identity is unspecified and unknown. --------- Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds test cases to existing tests for testing reductions where the identity is unspecified and unknown.