This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD] Introduce test to validate thread ID API #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Complementary compiler PR: intel/llvm#8569 |
sarnex
approved these changes
Mar 8, 2023
v-klochkov
reviewed
Mar 9, 2023
SYCL/ESIMD/thread_id_test.cpp
Outdated
| sycl::nd_range<1> Range(GlobalRange, LocalRange); | ||
|
|
||
| { | ||
| auto e = queue.submit([&](sycl::handler &cgh) { |
There was a problem hiding this comment.
minor comment: e is unused
Suggested change
| auto e = queue.submit([&](sycl::handler &cgh) { | |
| queue.submit([&](sycl::handler &cgh) { |
| shared_vector<int32_t> vector_output_thread_id(SIZE, -1, allocator); | ||
| shared_vector<int32_t> vector_output_subdevice_id(SIZE, -1, allocator); | ||
|
|
||
| auto GlobalRange = sycl::range<1>(SIZE); |
There was a problem hiding this comment.
Minor comment: The test has great mix of 2 naming styles: 'GlobalRange' and 'vector_output_subdevice_id_ptr'
It is a common problem for tests/sycl/esimd, but for new tests it would be nice to choose one style.
SYCL/ESIMD/thread_id_test.cpp
Outdated
| // UNSUPPORTED: cuda || hip | ||
| // RUN: %clangxx -fsycl %s -o %t.out | ||
| // RUN: %GPU_RUN_PLACEHOLDER %t.out | ||
| // XFAIL: gpu |
There was a problem hiding this comment.
Does it really fail with esimd-emulator?
There was a problem hiding this comment.
@fineg74 - This test probably passes with esimd_emulator (also coded as 'gpu'), but it is supposed to fail with this XFAIL.
v-klochkov
approved these changes
Mar 10, 2023
|
/verify with intel/llvm#8569 |
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…e-topic CMPLRTST-19973: skip run matrix_amxint8* on non-avx512 machine.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.