Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD] Mark tests that fail on gen9 windows as unsupported #1647

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

sarnex
Copy link

@sarnex sarnex commented Mar 9, 2023

The Gen9 GPU driver on Windows and Linux is different, so some tests don't work on Gen9 on Windows. Disable the ones that fail.

This change was implemented by our QA team, I'm just submitting the PR.

Thanks

@sarnex sarnex changed the title [SYCL] Mark tests that fail on gen9 windows as unsupported [SYCL][ESIMD] Mark tests that fail on gen9 windows as unsupported Mar 9, 2023
@sarnex sarnex marked this pull request as ready for review March 9, 2023 16:19
@sarnex sarnex requested a review from a team as a code owner March 9, 2023 16:19
Copy link

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I believe it has no effect in SYCLOS because:

  1. gpu-intel-gen9 parameter is never set there even if test is started on gen9.
  2. SYCLOS CI windows most likely uses newer HW (maybe Gen12).

@v-klochkov
Copy link

@sarnex - do you know BTW, why is this "Unsupported: windows && intel-gpu-gen9' needed for ESIMD tests and not needed for non-ESIMD tests (hundreds of tests)? Was that problem solved differently for non-ESIMD?

@v-klochkov
Copy link

I realized that I missed an existing proposal/discussion about aspects-detection for LIT tests.

@aelovikov-intel , @steffenlarsen, @bader - what is the plan for non-ESIMD tests?
My guess is that nobody wants adding 'UNSUPPORTED: intel-gpu-gen9 && windows" for hundreds LIT tests, but rather use some more localized & general solution, right?

@sarnex
Copy link
Author

sarnex commented Mar 14, 2023

@v-klochkov I'll send you all the relevant internal bug tracker link.

It's possible those are handled internally in the testing infrastructure, we would need to check with QA. I suggested in the bug tracker to make the change here in the repo instead, maybe that wasn't the right call.

@sarnex
Copy link
Author

sarnex commented Mar 20, 2023

@v-klochkov Are you okay with merging this one? QA is asking for it to be merged. Thanks

@v-klochkov v-klochkov merged commit 999b775 into intel:intel Mar 22, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
…tel#1647)

[SYCL] Mark tests that fail on gen9 windows as unsupported

Signed-off-by: Sarnie, Nick <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…tel/llvm-test-suite#1647)

[SYCL] Mark tests that fail on gen9 windows as unsupported

Signed-off-by: Sarnie, Nick <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants