This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix MemObjRemapping for devices without host unified memory #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for host unified memory within the test was insufficient, since the use of FileCheck ignores it. Instead, force the runtime to behave as if all devices support host unified memory for this test.
|
Makes use of an environment variable added by intel/llvm#3294 |
vladimirlaz
approved these changes
Mar 3, 2021
|
@sergey-semenov the test is passing without compiler change. Is that expected? |
|
Yes, the test passes as-is on devices with host unified memory support, which is the case in our automated testing. |
yuxianch
added a commit
to yuxianch/llvm-test-suite
that referenced
this pull request
Sep 13, 2021
Auto pulldown and update tc files for syclos branch on 20210902
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#167) The check for host unified memory within the test was insufficient, since the use of FileCheck ignores it. Instead, force the runtime to behave as if all devices support host unified memory for this test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for host unified memory within the test was insufficient,
since the use of FileCheck ignores it. Instead, force the runtime to
behave as if all devices support host unified memory for this test.