[SYCL] E2E test for interop_task with Level-Zero using get_mem() #168

smaslov-intel · 2021-03-04T23:37:57Z

Compiler support is coming in intel/llvm#3307
Signed-off-by: Sergey V Maslov [email protected]

vladimirlaz · 2021-03-09T07:42:47Z

@againull could you please fix the issue SYCL :: Plugin/interop-level-zero-interop-task-mem.cpp?

smaslov-intel · 2021-03-09T16:24:27Z

@vladimirlaz , what is the compiler used in this E2E testing? The compiler fix was merged long ago, but it still looks like the fail is because of not using the right compiler.

vladimirlaz · 2021-03-09T16:25:44Z

the latest available nightly from intel/llvm. @hanzhan1, @tfzhu could you please check and confirm, that the latest nightly is used?

smaslov-intel · 2021-03-09T17:02:09Z

I cannot reproduce it with ToT:

$ "env" "SYCL_BE=PI_LEVEL_ZERO" "env" "SYCL_DEVICE_FILTER=level_zero:gpu" ./a.out

WARNING: The legacy environment variables SYCL_BE and SYCL_DEVICE_TYPE are deprecated. Please use SYCL_DEVICE_FILTER instead. For details, please refer to https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md

zeContextGetStatus = 0
Memory type = 1

hanzhan1 · 2021-03-10T01:14:23Z

According to the log, pre-ci-linux used latest nightly version b1e1de06fdf8b9fa9b536e731f888bb6cd4f82be of date stamp 20210309_160000.

SYCL/Plugin/interop-level-zero-interop-task-mem.cpp

smaslov-intel · 2021-03-16T16:08:27Z

@vladimirlaz : the test is taken as is from a customer. Adding waits/catches/etc may cause completely different behavior so I don't think we need to beatify the tests.

vladimirlaz · 2021-03-16T17:12:09Z

@vladimirlaz : the test is taken as is from a customer. Adding waits/catches/etc may cause completely different behavior so I don't think we need to beatify the tests.

we need to be sure that the test is stable enough to use in regular testing. It should not be submitted if it is flaky or fails on some platforms.

smaslov-intel · 2021-03-16T17:18:07Z

I agree, we should not add flaky tests for sure. Are you seeing flaky behavior in the test? The only fail that I see currently is stable:


[2021-03-16T05:55:48.918Z] ******************** TEST 'SYCL :: Plugin/interop-level-zero-interop-task-mem.cpp' FAILED ********************
[2021-03-16T05:55:48.918Z] Script:
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] : 'RUN: at line 2';    /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/bin/clang++     -fsycl -fsycl-targets=spir64-unknown-unknown-sycldevice  -lze_loader  -I/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/include/sycl/.. /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm-test-suite/SYCL/Plugin/interop-level-zero-interop-task-mem.cpp -o /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out
[2021-03-16T05:55:48.918Z] : 'RUN: at line 3';    env SYCL_DEVICE_FILTER=level_zero:gpu  /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] Exit Code: -6
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] Command Output (stdout):
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] $ ":" "RUN: at line 2"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/bin/clang++" "-fsycl" "-fsycl-targets=spir64-unknown-unknown-sycldevice" "-lze_loader" "-I/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/include/sycl/.." "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm-test-suite/SYCL/Plugin/interop-level-zero-interop-task-mem.cpp" "-o" "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ ":" "RUN: at line 3"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ "env" "SYCL_DEVICE_FILTER=level_zero:gpu" "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out"
[2021-03-16T05:55:48.918Z] # command output:
[2021-03-16T05:55:48.918Z] zeContextGetStatus = 0
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] # command stderr:
[2021-03-16T05:55:48.918Z] terminate called after throwing an instance of 'char const*'
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] error: command failed with exit status: -6

BUT I cannot reproduce it locally. Any suggestions?

vladimirlaz · 2021-03-16T18:02:12Z

I agree, we should not add flaky tests for sure. Are you seeing flaky behavior in the test? The only fail that I see currently is stable:


[2021-03-16T05:55:48.918Z] ******************** TEST 'SYCL :: Plugin/interop-level-zero-interop-task-mem.cpp' FAILED ********************
[2021-03-16T05:55:48.918Z] Script:
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] : 'RUN: at line 2';    /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/bin/clang++     -fsycl -fsycl-targets=spir64-unknown-unknown-sycldevice  -lze_loader  -I/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/include/sycl/.. /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm-test-suite/SYCL/Plugin/interop-level-zero-interop-task-mem.cpp -o /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out
[2021-03-16T05:55:48.918Z] : 'RUN: at line 3';    env SYCL_DEVICE_FILTER=level_zero:gpu  /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] Exit Code: -6
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] Command Output (stdout):
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] $ ":" "RUN: at line 2"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/bin/clang++" "-fsycl" "-fsycl-targets=spir64-unknown-unknown-sycldevice" "-lze_loader" "-I/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/include/sycl/.." "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm-test-suite/SYCL/Plugin/interop-level-zero-interop-task-mem.cpp" "-o" "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ ":" "RUN: at line 3"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ "env" "SYCL_DEVICE_FILTER=level_zero:gpu" "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out"
[2021-03-16T05:55:48.918Z] # command output:
[2021-03-16T05:55:48.918Z] zeContextGetStatus = 0
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] # command stderr:
[2021-03-16T05:55:48.918Z] terminate called after throwing an instance of 'char const*'
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] error: command failed with exit status: -6

BUT I cannot reproduce it locally. Any suggestions?

I agree, we should not add flaky tests for sure. Are you seeing flaky behavior in the test? The only fail that I see currently is stable:


[2021-03-16T05:55:48.918Z] ******************** TEST 'SYCL :: Plugin/interop-level-zero-interop-task-mem.cpp' FAILED ********************
[2021-03-16T05:55:48.918Z] Script:
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] : 'RUN: at line 2';    /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/bin/clang++     -fsycl -fsycl-targets=spir64-unknown-unknown-sycldevice  -lze_loader  -I/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/include/sycl/.. /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm-test-suite/SYCL/Plugin/interop-level-zero-interop-task-mem.cpp -o /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out
[2021-03-16T05:55:48.918Z] : 'RUN: at line 3';    env SYCL_DEVICE_FILTER=level_zero:gpu  /localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] Exit Code: -6
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] Command Output (stdout):
[2021-03-16T05:55:48.918Z] --
[2021-03-16T05:55:48.918Z] $ ":" "RUN: at line 2"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/bin/clang++" "-fsycl" "-fsycl-targets=spir64-unknown-unknown-sycldevice" "-lze_loader" "-I/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm.obj/include/sycl/.." "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/llvm-test-suite/SYCL/Plugin/interop-level-zero-interop-task-mem.cpp" "-o" "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ ":" "RUN: at line 3"
[2021-03-16T05:55:48.918Z] note: command had no output on stdout or stderr
[2021-03-16T05:55:48.918Z] $ "env" "SYCL_DEVICE_FILTER=level_zero:gpu" "/localdisk2/llvm-test-suite_Jenkins/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-Lin/build/SYCL/Plugin/Output/interop-level-zero-interop-task-mem.cpp.tmp.out"
[2021-03-16T05:55:48.918Z] # command output:
[2021-03-16T05:55:48.918Z] zeContextGetStatus = 0
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] # command stderr:
[2021-03-16T05:55:48.918Z] terminate called after throwing an instance of 'char const*'
[2021-03-16T05:55:48.918Z] 
[2021-03-16T05:55:48.918Z] error: command failed with exit status: -6

BUT I cannot reproduce it locally. Any suggestions?

According to logs it looks like char* string was thrown. Adding try/catch wrapper does not affect the code but helps to analyze failures.

bader · 2021-03-26T12:22:21Z

@smaslov-intel, do you have updates for this PR?

SYCL/Plugin/interop-level-zero-interop-task-mem.cpp

vladimirlaz · 2021-05-17T08:14:05Z

@smaslov-intel, Is this PR still needed?

smaslov-intel · 2021-05-17T19:44:06Z

@smaslov-intel, Is this PR still needed?

Yes. I can't reproduce the reported fail locally. How to restart the Jenkins testing?

vladimirlaz · 2021-05-18T05:08:58Z

@smaslov-intel, I have restarted testing.

Signed-off-by: Sergey V Maslov <[email protected]>

smaslov-intel · 2021-05-19T00:42:29Z

[2021-05-19T00:20:56.729Z] New failures found: ['SYCL::Basic/half_type.cpp', 'SYCL::Basic/reqd_work_group_size.cpp', 'SYCL::Functor/kernel_functor.cpp', 'SYCL::Plugin/interop-level-zero-interop-task-mem.cpp', 'SYCL::Reduction/reduction_queue_parallel_for.cpp', 'SYCL::Reduction/reduction_nd_s0_rw.cpp', 'SYCL::USM/memset.cpp']

@vladimirlaz : I have no clue how to proceed with this.

The test I am adding passes locally: interop-level-zero-interop-task-mem.cpp
Six other tests are showing as new fails, although I didn't touch them.

Any idea?

vladimirlaz · 2021-05-19T13:57:50Z

The same tests are failing for other PRs.

smaslov-intel · 2021-05-19T15:00:50Z

The same tests are failing for other PRs.

Does it mean they are real fails that need to be analyzed/fixed?
Why are they showing as "new failures"?

bader · 2021-05-19T15:04:36Z

Please, keep 0 failing tests.

vladimirlaz · 2021-05-20T05:58:56Z

This is environment issue which is under analysis by tools guys.

…el/llvm-test-suite#168) Signed-off-by: Sergey V Maslov <[email protected]>

smaslov-intel mentioned this pull request Mar 4, 2021

[SYCL] Support interop_task with Level-Zero using get_mem() intel/llvm#3307

Merged

smaslov-intel requested a review from againull March 4, 2021 23:41

vladimirlaz reviewed Mar 10, 2021

View reviewed changes

SYCL/Plugin/interop-level-zero-interop-task-mem.cpp Show resolved Hide resolved

vladimirlaz suggested changes Mar 16, 2021

View reviewed changes

SYCL/Plugin/interop-level-zero-interop-task-mem.cpp Show resolved Hide resolved

SYCL/Plugin/interop-level-zero-interop-task-mem.cpp Show resolved Hide resolved

SYCL/Plugin/interop-level-zero-interop-task-mem.cpp Show resolved Hide resolved

smaslov-intel commented Mar 26, 2021

View reviewed changes

SYCL/Plugin/interop-level-zero-interop-task-mem.cpp Show resolved Hide resolved

vladimirlaz self-requested a review April 21, 2021 06:47

mikhail-nikolskiy mentioned this pull request Apr 23, 2021

[SYCL] E2E test for interop_task with Level-Zero and OpenCL #252

Merged

smaslov-intel changed the title ~~[SYCL] E2E test fot interop_task with Level-Zero using get_mem()~~ [SYCL] E2E test for interop_task with Level-Zero using get_mem() May 17, 2021

vladimirlaz previously approved these changes May 18, 2021

View reviewed changes

[SYCL] E2E test fot interop_task with Level-Zero using get_mem()

4aaa02c

Signed-off-by: Sergey V Maslov <[email protected]>

smaslov-intel dismissed vladimirlaz’s stale review via 4aaa02c May 18, 2021 22:25

smaslov-intel force-pushed the intel branch from 1bdd2d2 to 4aaa02c Compare May 18, 2021 22:25

vladimirlaz merged commit 29b4273 into intel:intel May 19, 2021

aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023

[SYCL] E2E test fot interop_task with Level-Zero using get_mem() (int…

5190d42

…el/llvm-test-suite#168) Signed-off-by: Sergey V Maslov <[email protected]>

[SYCL] E2E test for interop_task with Level-Zero using get_mem() #168

[SYCL] E2E test for interop_task with Level-Zero using get_mem() #168

Uh oh!

Conversation

smaslov-intel commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vladimirlaz commented Mar 9, 2021

Uh oh!

smaslov-intel commented Mar 9, 2021

Uh oh!

vladimirlaz commented Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smaslov-intel commented Mar 9, 2021

Uh oh!

hanzhan1 commented Mar 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smaslov-intel commented Mar 16, 2021

Uh oh!

vladimirlaz commented Mar 16, 2021

Uh oh!

smaslov-intel commented Mar 16, 2021

Uh oh!

vladimirlaz commented Mar 16, 2021

Uh oh!

bader commented Mar 26, 2021

Uh oh!

Uh oh!

vladimirlaz commented May 17, 2021

Uh oh!

smaslov-intel commented May 17, 2021

Uh oh!

vladimirlaz commented May 18, 2021

Uh oh!

smaslov-intel commented May 19, 2021

Uh oh!

vladimirlaz commented May 19, 2021

Uh oh!

smaslov-intel commented May 19, 2021

Uh oh!

bader commented May 19, 2021

Uh oh!

vladimirlaz commented May 20, 2021

Uh oh!

Uh oh!

smaslov-intel commented Mar 4, 2021 •

edited

Loading

vladimirlaz commented Mar 9, 2021 •

edited

Loading