This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Updated tests to comply with SYCL 2020 aspect list #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2023 05:16
The host, int64*, usm_restricted_shared_allocations, and usm_system_allocator aspects are either removed or deprecated in SYCL 2020. The implementations will be removed at a later date but the tests can be updated to reflect the changes.
|
Test changes are valid without new changes to intel/llvm. Merging these. |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-test-suite#1685) This patch updates the E2E tests to account for the changes made to aspects in [Section 4.6.4.3](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:device-aspects) of the specification: - The concept of a "host" device no longer exists in SYCL 2020 - any `host` should now be a `cpu`, so the aspect has been deprecated accordingly. - `usm_restricted_shared_allocations` has been removed. - `usm_system_allocator` has been renamed `usm_system_allocations`. - `int64_*` aspects were replaced with `atomic64`, so no longer should be tested.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the E2E tests to account for the changes made to aspects in Section 4.6.4.3 of the specification:
hostshould now be acpu, so the aspect has been deprecated accordingly.usm_restricted_shared_allocationshas been removed.usm_system_allocatorhas been renamedusm_system_allocations.int64_*aspects were replaced withatomic64, so no longer should be tested.(May require intel/llvm#8751 but should pass without.)