Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Add a test for SYCL_INTEL_local_memory extension #176

Merged
merged 4 commits into from
Apr 5, 2021
Merged

Add a test for SYCL_INTEL_local_memory extension #176

merged 4 commits into from
Apr 5, 2021

Conversation

sergey-semenov
Copy link

No description provided.

@sergey-semenov
Copy link
Author

Depends on and checks the changes from intel/llvm#3329 and intel/llvm#3228

Pennycook
Pennycook previously approved these changes Mar 10, 2021
Copy link

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@Pennycook
Copy link

Pennycook commented Mar 10, 2021

@jbrodman suggested that it might be a good idea to demonstrate some alternative ways to use the pointer, in case developers are basing their code on our tests, e.g.:

auto Ptr = group_local_memory_for_overwrite<int[WgSize]>(Item.get_group());

and

Foo& Ref = *group_local_memory(Item.get_group(), ...);

If all of these syntax options are functionally equivalent (as I think they are) then we might not need to actually test them, but it might still be worth adding a comment or two to let readers know other options are available.

@sergey-semenov
Copy link
Author

@Pennycook Added a comment on this.

@mlychkov mlychkov marked this pull request as ready for review March 30, 2021 06:34
@@ -0,0 +1,95 @@
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New directory is added. Could you please set correct code owner (in .github/CODEOWNERS)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added myself as the code owner. @Pennycook Do you mind being set as the second code owner for the group local memory tests? (I this can be done as a separate PR, so that it does not block merging this one).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pennycook Do you mind being set as the second code owner for the group local memory tests?

Fine by me.

@vladimirlaz vladimirlaz merged commit 0d31277 into intel:intel Apr 5, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants