This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix SYCL_DEVICE_FILTER setting #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HOST device is not automatically available when SYCL_DEVICE_FILTER is set. SYCL_DEVICE_FILTER has to list 'host' explicitly if a test needs it. Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
bso-intel
commented
Mar 30, 2021
| @@ -45,12 +45,19 @@ int main() { | |||
| device d = cs.select_device(); | |||
| std::cout << "CPU device is found: " << d.is_cpu() << std::endl; | |||
| } | |||
| // HOST device is always available regardless of SYCL_DEVICE_FILTER | |||
| /* | |||
| // TODO: enable this once SYCL_DEVICE_FILTER PR is merged. | |||
There was a problem hiding this comment.
intel/llvm#3397 needs to be merged first to enable this test.
PR-3397 forces SYCL_DEVICE_FILTER to only provide designated devices.
|
@alexbatashev Thanks. |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Signed-off-by: Byoungro So <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOST device is not automatically available when SYCL_DEVICE_FILTER is set.
SYCL_DEVICE_FILTER has to list 'host' explicitly if a test needs it.
Signed-off-by: Byoungro So [email protected]