-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL][L0] Fix pinned memory allocation test. #215
Conversation
Pinned memory allocation is not currently supported by L0. Signed-off-by: rbegam <[email protected]>
@@ -1,4 +1,4 @@ | |||
// REQUIRES: level_zero || cuda | |||
// REQUIRES: cuda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the test failing on Level_Zero satbily? If it is I would prefer to mark test as XFAIL: level_zero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified the CHECK
@rbegam : why does it fail? I known we don't truly support pinned memory, but my expectation is that it is just a nop for Level-Zero for now. So why this is failing? |
@smaslov-intel, this test checks SYCL_PI_TRACE for zeMemAllocHost() (https://github.com/intel/llvm-test-suite/pull/215/files#diff-fb8c60f542fd5b66745807155566683a3d084c409b5375d523268bb46f06d222L43) while buffer create. This is failing for the discrete gpu as we don't call zeMemAllocHost() anymore. For integrated it's passing. |
Ah, OK. Then I suggest that we remove the check for |
@smaslov-intel cuda has that call checked. let's separate the tests for level_zero (remove zeMemAllocHost) and cuda (as is). |
Signed-off-by: rbegam <[email protected]>
But there is no |
Signed-off-by: rbegam <[email protected]>
) Signed-off-by: rbegam <[email protected]>
Pinned memory allocation is not currently supported by L0.
Signed-off-by: rbegam [email protected]