Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[ESIMD] Enabled back kmeans test by reducing the number of iterations #309

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

DenisBakhvalov
Copy link

No description provided.

@vladimirlaz
Copy link

@DenisBakhvalov, @kbobrovs Does it make sense to have multiple iterations here as soon as these tests are functional? Remove iterative execution will save extra CI resources.

@kbobrovs
Copy link

kbobrovs commented Jun 3, 2021

@vladimirlaz - seems like a good point to me. adding @kychendev for possible comments.

@kychendev
Copy link

KMeans algorithm requires multiple iterations for the centroids to converge. Reducing the number of iterations may result in poor results, although it wouldn't affect validation as we are comparing with CPU processing output after the same number of iterations. Was this test disabled due to time out issue? Another way could be to reduce the input size.

@kbobrovs
Copy link

kbobrovs commented Jun 3, 2021

KMeans algorithm requires multiple iterations for the centroids to converge. Reducing the number of iterations may result in poor results, although it wouldn't affect validation as we are comparing with CPU processing output after the same number of iterations. Was this test disabled due to time out issue? Another way could be to reduce the input size.

Thanks for clarification. Yes, the test was disabled due to timeout (which maybe a sign of perf degradation, but this is another problem).
So I think as long as we can reliably verify results accuracy doesn't matter in this case. So I'd say reduce to few iterations (and possibly input size too if it can be done easily, otherwise as a subsequent PR).

@kbobrovs
Copy link

kbobrovs commented Jun 3, 2021

Approving, as the patch fixes the immediate problem, and further improvements can be done atop. Leave to @vladimirlaz.

@vladimirlaz vladimirlaz merged commit 907cce4 into intel:intel Jun 4, 2021
smaslov-intel pushed a commit to smaslov-intel/llvm-test-suite that referenced this pull request Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants