Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][L0] check for no event leaks #329

Merged
merged 5 commits into from
Jun 29, 2021

Conversation

smaslov-intel
Copy link

Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel changed the title [SYCL][L0] check for not event leaks [SYCL][L0] check for no event leaks Jun 27, 2021
Copy link

@kbsmith-intel kbsmith-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this test makes me wonder if we should also create or use other tests, and add a LEAK check to them.

Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Author

Overall, this test makes me wonder if we should also create or use other tests, and add a LEAK check to them.

We already have testing with ZE_DEBUG=-1, which should check the LEAKs too. I will contact QA to see if it's actually running.

Signed-off-by: Sergey V Maslov <[email protected]>
//
// clang-format on
//
// NOTE: The 129 value below is to be larger thatn the "128" heuristic in

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the 128 heuristic in addSharedEvernt is changed to be larger (which it probably should be) then will this test
need to be updated?

Should the value be chosen to be MUCH larger than the current heuristic?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, put 1000.

Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Copy link

@kbsmith-intel kbsmith-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirlaz vladimirlaz merged commit c8eaa9b into intel:intel Jun 29, 2021
smaslov-intel added a commit to smaslov-intel/llvm-test-suite that referenced this pull request Aug 12, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants