-
Notifications
You must be signed in to change notification settings - Fork 130
Conversation
Signed-off-by: Sergey V Maslov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this test makes me wonder if we should also create or use other tests, and add a LEAK check to them.
Signed-off-by: Sergey V Maslov <[email protected]>
We already have testing with ZE_DEBUG=-1, which should check the LEAKs too. I will contact QA to see if it's actually running. |
Signed-off-by: Sergey V Maslov <[email protected]>
// | ||
// clang-format on | ||
// | ||
// NOTE: The 129 value below is to be larger thatn the "128" heuristic in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the 128 heuristic in addSharedEvernt is changed to be larger (which it probably should be) then will this test
need to be updated?
Should the value be chosen to be MUCH larger than the current heuristic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, put 1000.
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov [email protected]