This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix tests for assert #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 28, 2021 22:26
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
requested review from
AlexeySachkov,
Fznamznon and
a team
as code owners
|
@AlexeySachkov , @Fznamznon , possibly some of the tests are for features which are owned by you, so please, pay extreme attention to changes of those tests in this patch. |
added 3 commits
June 28, 2021 22:31
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
requested review from
AGindinson,
dm-vodopyanov,
romanovvlad and
vladimirlaz
as code owners
added 4 commits
July 1, 2021 16:01
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
changed the title
Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
changed the title
…er of program builds Signed-off-by: Sergey Kanaev <[email protected]>
…er of program builds Signed-off-by: Sergey Kanaev <[email protected]>
s-kanaev
dismissed stale reviews from AGindinson, vladimirlaz, kbobrovs, MrSidims, mlychkov, and dm-vodopyanov
via
ce5ca4b
mlychkov
approved these changes
Jul 8, 2021
s-kanaev
requested review from
romanovvlad,
dm-vodopyanov,
MrSidims,
kbobrovs,
AGindinson and
vladimirlaz
dm-vodopyanov
approved these changes
Jul 9, 2021
MrSidims
approved these changes
Jul 11, 2021
vladimirlaz
approved these changes
Jul 12, 2021
AGindinson
approved these changes
Jul 12, 2021
Fznamznon
reviewed
Jul 12, 2021
Comment on lines
+21
to
+22
| // FIXME: Change the behavior when proper automation for assert support is | ||
| // introduced |
There was a problem hiding this comment.
Will it be fixed by intel/llvm#3767 ?
There was a problem hiding this comment.
Per offline discussion, agreed to elaborate on the comment in distinct patch.
| // RUN: %clangxx -fsycl-device-only -Xclang -fenable-sycl-dae -Xclang -fsycl-int-header=int_header.h %s -c -o device_code.bc -Wno-sycl-strict | ||
| // RUN: %clangxx %cxx_std_optionc++17 %include_option int_header.h %debug_option -c %s -o host_code.o %sycl_options -Wno-sycl-strict | ||
| // FIXME Disabled fallback assert as it'll require either online linking or | ||
| // explicit offline linking step here |
There was a problem hiding this comment.
Why not to add explicit offline linking like in previous test?
There was a problem hiding this comment.
Per offline discussion, agreed to add offline linking to this test in distinct patch.
Comment on lines
+14
to
+15
| // FIXME Disabled use of devicelib by assert feature until the 2-step build gets | ||
| // fixed. |
There was a problem hiding this comment.
Will it be fixed by intel/llvm#3767 ?
There was a problem hiding this comment.
This one won't be fixed by intel/llvm#3767. There's an issue in driver which isn't connected to intel/llvm#3767. The issue can be encountered when using any devicelib function and compiling the same way it's done in this test. @mdtoguchi is aware of the issue.
Fznamznon
approved these changes
Jul 12, 2021
AlexeySachkov
approved these changes
Jul 12, 2021
s-kanaev
pushed a commit
to s-kanaev/llvm-test-suite
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Sergey Kanaev <[email protected]>
vladimirlaz
pushed a commit
that referenced
this pull request
Jul 14, 2021
Signed-off-by: Sergey Kanaev <[email protected]>
smaslov-intel
pushed a commit
to smaslov-intel/llvm-test-suite
that referenced
this pull request
Aug 12, 2021
smaslov-intel
pushed a commit
to smaslov-intel/llvm-test-suite
that referenced
this pull request
Aug 12, 2021
Signed-off-by: Sergey Kanaev <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes of regressions for intel/llvm#3767