This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Adjust multiple tests to queue::wait() changes #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust tests to expect a call to piQueueFinish rather than piEventsWait as part of queue::wait().
|
Adjusts tests to fix regressions once intel/llvm#4044 is merged. |
With a recent update to the runtime pull request blocked commands are no longer waited for during enqueueing of their users. This introduces more cases where host tasks are used to "glue" events from different contexts, which leads to a change to expected order of PI calls in the test.
|
Please fix the CI regressions on the updated tests. |
Since queue::wait() changes introduced host tasks to enqueue-arg-order-image.cpp, the order of calls may vary from run to run. Replace CHECK with CHECK-DAG to allow any ordering of the PI calls that are made by a host task.
sergey-semenov
dismissed stale reviews from smaslov-intel and s-kanaev
via
8726dbb
smaslov-intel
approved these changes
Jul 7, 2021
|
The only failed test in CI is |
smaslov-intel
pushed a commit
to smaslov-intel/llvm-test-suite
that referenced
this pull request
Aug 12, 2021
Adjust tests to expect a call to piQueueFinish rather than piEventsWait as part of queue::wait(), as well as release of events for queue USM operations or non-host commands with no implicit dependencies right after their submission. Additionally, blocked commands are no longer always waited for before enqueueing of their users. This introduces more cases where host tasks are used to "glue" events from different contexts, which makes it so that the order of some calls in the enqueue-arg-order-image test may vary from run to run.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…t-suite#338) Adjust tests to expect a call to piQueueFinish rather than piEventsWait as part of queue::wait(), as well as release of events for queue USM operations or non-host commands with no implicit dependencies right after their submission. Additionally, blocked commands are no longer always waited for before enqueueing of their users. This introduces more cases where host tasks are used to "glue" events from different contexts, which makes it so that the order of some calls in the enqueue-arg-order-image test may vary from run to run.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust tests to expect a call to piQueueFinish rather than piEventsWait
as part of queue::wait(), as well as release of events for queue USM
operations or non-host commands with no implicit dependencies right after
their submission.
Additionally, blocked commands are no longer always waited for before enqueueing
of their users. This introduces more cases where host tasks are used to "glue"
events from different contexts, which makes it so that the order of some calls in the
enqueue-arg-order-image test may vary from run to run.