Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Xfail tests failing after driver uplift #364

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

vladimirlaz
Copy link

The tests are failing with GPU RT 30.0.100.9667 on windows

The tests are failing with GPU RT 30.0.100.9667 on windows
@@ -10,6 +10,9 @@
// UNSUPPORTED: cuda
// CUDA is not compatible with SPIR.

// The test is failing with GPU RT 30.0.100.9667

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test also checks combination without GPU at all and it get's disabled because of unrelated GPU fail. I can't come up with combinations of options that allows to disable concrete RUN lines on concrete OS. We might consider re-arranging this test.

Copy link
Author

@vladimirlaz vladimirlaz Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test will run only on a machine with CPU+GPU+Accelerator available,
As for my understanding, it is built for all target devices in the single fat binary. Then fat binary is run for every target device to check that every device image is functional.

The test is executed only if all devices are available. No need to disable particular device.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for my understanding, it is built for all target devices in the single fat binary. Then fat binary is run for every target device to check that every device image is functional.

Yes, it is done on lines 18-22. On next lines device code is compiled manually by each of AOT compilers and different combinations of resulting binaries are supplied to a fat binary via -fsycl-add targets option. There is only CPU&FPGA run starting on line 51.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address that it we can split the test in separate PR.

@vladimirlaz vladimirlaz merged commit bb842e3 into intel:intel Jul 15, 2021
smaslov-intel pushed a commit to smaslov-intel/llvm-test-suite that referenced this pull request Aug 12, 2021
The tests are failing with GPU RT 30.0.100.9667 on windows
@vladimirlaz vladimirlaz deleted the xfail_windows_test branch February 2, 2022 10:45
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…#364)

The tests are failing with GPU RT 30.0.100.9667 on windows
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants