-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Xfail tests failing after driver uplift #364
Conversation
The tests are failing with GPU RT 30.0.100.9667 on windows
@@ -10,6 +10,9 @@ | |||
// UNSUPPORTED: cuda | |||
// CUDA is not compatible with SPIR. | |||
|
|||
// The test is failing with GPU RT 30.0.100.9667 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test also checks combination without GPU at all and it get's disabled because of unrelated GPU fail. I can't come up with combinations of options that allows to disable concrete RUN lines on concrete OS. We might consider re-arranging this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test will run only on a machine with CPU+GPU+Accelerator available,
As for my understanding, it is built for all target devices in the single fat binary. Then fat binary is run for every target device to check that every device image is functional.
The test is executed only if all devices are available. No need to disable particular device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for my understanding, it is built for all target devices in the single fat binary. Then fat binary is run for every target device to check that every device image is functional.
Yes, it is done on lines 18-22. On next lines device code is compiled manually by each of AOT compilers and different combinations of resulting binaries are supplied to a fat binary via -fsycl-add targets option. There is only CPU&FPGA run starting on line 51.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To address that it we can split the test in separate PR.
The tests are failing with GPU RT 30.0.100.9667 on windows
…#364) The tests are failing with GPU RT 30.0.100.9667 on windows
The tests are failing with GPU RT 30.0.100.9667 on windows